Update: swap pin-project for pin-project-lite #1503
Conversation
Velfi
changed the title
| /// | ||
| /// This will yield an `Err(SdkError::ConstructionFailure)` if a message can't be | ||
| /// marshalled into an Event Stream frame, (e.g., if the message payload was too large). | ||
| pub struct MessageStreamAdapter { |
There was a problem hiding this comment.
The <T, E> generic args disappeared? Make sure to test this crate with --all-features since the event stream parts aren't on by default.
| #[pin] | ||
| stream: Pin<Box<dyn Stream<Item = Result<T, BoxError>> + Send>>, |
There was a problem hiding this comment.
Is pin projection actually needed here if the member is Pin? It seems like it shouldn't be, but I'm not 100% sure.
There was a problem hiding this comment.
I don't understand why it needs to be Pin but if I remove it then the compiler starts complaining about it not implementing some obtuse generic traits.
| Once { | ||
| #[pin] |
There was a problem hiding this comment.
Do Once and Dyn actually need #[pin]? I understand why Streaming needs it, but I'm fuzzy on why these would need it.
There was a problem hiding this comment.
Dyn complains without it but Once seems to be ok when I remove it
| pin_project! { | ||
| #[project = EnumProj] | ||
| pub enum MapRequestFuture<F, E> { | ||
| Inner { |
There was a problem hiding this comment.
Not really related to your changes, but the name Inner is kind of confusing to me here. Maybe we should have called it Pending or something? Is there a broader idiomatic pattern for this with futures?
There was a problem hiding this comment.
Looking at it, I would name the variants Pending and Complete. @rcoh what do you think?
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
| #[pin] | ||
| stream: Pin<Box<dyn Stream<Item = Result<T, BoxError>> + Send>>, |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Motivation and Context
#932
Description
swap pin-project for pin-project-lite
Testing
ran existing tests
Checklist
CHANGELOG.next.tomlif I made changes to the smithy-rs codegen or runtime cratesCHANGELOG.next.tomlif I made changes to the AWS SDK, generated SDK code, or SDK runtime cratesBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.