Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename aws_types::config::Config to sdk_config::SdkConfig #1241

Merged
merged 13 commits into from
Mar 10, 2022
Merged

Rename aws_types::config::Config to sdk_config::SdkConfig #1241

merged 13 commits into from
Mar 10, 2022

Conversation

Velfi
Copy link
Contributor

@Velfi Velfi commented Mar 8, 2022

Motivation and Context

aws-sdk-rust#406

Description

rename aws_types::config::Config to sdk_config::SdkConfig and update everything referencing the old name

Testing

ran existing tests

Checklist

  • I have updated CHANGELOG.next.toml if I made changes to the smithy-rs codegen or runtime crates
  • I have updated CHANGELOG.next.toml if I made changes to the AWS SDK, generated SDK code, or SDK runtime crates

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

rename: aws_types::config::Config to sdk_config::SdkConfig
18e426c 
update: code affected by SdkConfig rename
update: CHANGELOG.next.toml
@Velfi Velfi requested a review from a team as a code owner March 8, 2022 19:48
@github-actions
Copy link

github-actions bot commented Mar 8, 2022

A new doc preview is ready to view.

@github-actions
Copy link

github-actions bot commented Mar 8, 2022

A new doc preview is ready to view.

@github-actions
Copy link

github-actions bot commented Mar 8, 2022

A new generated diff is ready to view.

@github-actions
Copy link

github-actions bot commented Mar 8, 2022

A new generated diff is ready to view.

@Velfi Velfi mentioned this pull request Mar 8, 2022
Closed
@github-actions
Copy link

github-actions bot commented Mar 8, 2022

Rust Wrk benchmark report:

Duration: 60 sec, Connections: 64, Threads: 8

Measurement Deviation Current Old
Requests/sec 0.19% 65783.24 65660.51
Total requests 0.24% 3950326 3940721
Total errors NaN% 0 0
Total successes 0.24% 3950326 3940721
Average latency ms 0.00% 1.02 1.02
Minimum latency ms 0.00% 0.02 0.02
Maximum latency ms 0.32% 31 30.9
Stdev latency ms 7.04% 0.76 0.71
Transfer Mb 0.24% 410.64 409.64
Connect errors NaN% 0 0
Read errors NaN% 0 0
Write errors NaN% 0 0
Status errors (not 2xx/3xx) NaN% 0 0
Timeout errors NaN% 0 0

@github-actions
Copy link

github-actions bot commented Mar 8, 2022

Rust Wrk benchmark report:

Duration: 60 sec, Connections: 64, Threads: 8

Measurement Deviation Current Old
Requests/sec 2.40% 73418.62 71695.46
Total requests 2.40% 4408612 4305258
Total errors NaN% 0 0
Total successes 2.40% 4408612 4305258
Average latency ms -3.09% 0.94 0.97
Minimum latency ms 0.00% 0.02 0.02
Maximum latency ms -12.36% 28.37 32.37
Stdev latency ms -2.44% 0.8 0.82
Transfer Mb 2.40% 458.28 447.53
Connect errors NaN% 0 0
Read errors NaN% 0 0
Write errors NaN% 0 0
Status errors (not 2xx/3xx) NaN% 0 0
Timeout errors NaN% 0 0

rcoh
rcoh reviewed Mar 9, 2022
View reviewed changes
Copy link
Collaborator

@rcoh rcoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, let's just discuss possible re-export

@github-actions
Copy link

github-actions bot commented Mar 9, 2022

A new generated diff is ready to view.

@github-actions
Copy link

github-actions bot commented Mar 9, 2022

A new generated diff is ready to view.

@github-actions
Copy link

github-actions bot commented Mar 9, 2022

A new doc preview is ready to view.

rcoh
rcoh approved these changes Mar 9, 2022
View reviewed changes
Copy link
Collaborator

@rcoh rcoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions
Copy link

github-actions bot commented Mar 9, 2022

A new doc preview is ready to view.

@github-actions
Copy link

github-actions bot commented Mar 9, 2022

A new generated diff is ready to view.

@github-actions
Copy link

A new doc preview is ready to view.

@github-actions
Copy link

A new generated diff is ready to view.

@github-actions
Copy link

Rust Wrk benchmark report:

Duration: 60 sec, Connections: 64, Threads: 8

Measurement Deviation Current Old
Requests/sec 3.98% 69015.6 66373.64
Total requests 4.02% 4144344 3984162
Total errors NaN% 0 0
Total successes 4.02% 4144344 3984162
Average latency ms -2.97% 0.98 1.01
Minimum latency ms 0.00% 0.02 0.02
Maximum latency ms -44.76% 34.08 61.69
Stdev latency ms 0.00% 0.71 0.71
Transfer Mb 4.02% 430.81 414.16
Connect errors NaN% 0 0
Read errors NaN% 0 0
Write errors NaN% 0 0
Status errors (not 2xx/3xx) NaN% 0 0
Timeout errors NaN% 0 0

@rcoh
Update CHANGELOG.next.toml
60d2bc4 
Co-authored-by: Russell Cohen <[email protected]>
@github-actions
Copy link

A new doc preview is ready to view.

@github-actions
Copy link

A new generated diff is ready to view.

@github-actions
Copy link

Rust Wrk benchmark report:

Duration: 60 sec, Connections: 64, Threads: 8

Measurement Deviation Current Old
Requests/sec 6.94% 72108.64 67426.89
Total requests 6.98% 4330427 4047923
Total errors NaN% 0 0
Total successes 6.98% 4330427 4047923
Average latency ms -4.00% 0.96 1
Minimum latency ms 0.00% 0.02 0.02
Maximum latency ms -11.97% 32.66 37.1
Stdev latency ms 15.28% 0.83 0.72
Transfer Mb 6.98% 450.15 420.78
Connect errors NaN% 0 0
Read errors NaN% 0 0
Write errors NaN% 0 0
Status errors (not 2xx/3xx) NaN% 0 0
Timeout errors NaN% 0 0

add: deprecated config helper
dac7c34 
update: use reexported SdkConfig in docs referencing it
@github-actions
Copy link

A new generated diff is ready to view.

@github-actions
Copy link

A new doc preview is ready to view.

@github-actions
Copy link

Rust Wrk benchmark report:

Duration: 60 sec, Connections: 64, Threads: 8

Measurement Deviation Current Old
Requests/sec -6.92% 65262.28 70116.11
Total requests -6.97% 3917459 4210840
Total errors NaN% 0 0
Total successes -6.97% 3917459 4210840
Average latency ms 4.08% 1.02 0.98
Minimum latency ms 0.00% 0.02 0.02
Maximum latency ms -19.37% 25.6 31.75
Stdev latency ms -22.09% 0.67 0.86
Transfer Mb -6.97% 407.22 437.72
Connect errors NaN% 0 0
Read errors NaN% 0 0
Write errors NaN% 0 0
Status errors (not 2xx/3xx) NaN% 0 0
Timeout errors NaN% 0 0

@github-actions
Copy link

A new doc preview is ready to view.

@github-actions
Copy link

A new generated diff is ready to view.

@github-actions
Copy link

A new doc preview is ready to view.

@github-actions
Copy link

A new generated diff is ready to view.

@github-actions
Copy link

A new generated diff is ready to view.

@github-actions
Copy link

A new doc preview is ready to view.

@github-actions
Copy link

Rust Wrk benchmark report:

Duration: 60 sec, Connections: 64, Threads: 8

Measurement Deviation Current Old
Requests/sec 13.75% 72204.64 63474.25
Total requests 13.64% 4335222 3814714
Total errors NaN% 0 0
Total successes 13.64% 4335222 3814714
Average latency ms -6.80% 0.96 1.03
Minimum latency ms 0.00% 0.02 0.02
Maximum latency ms 5.12% 28.15 26.78
Stdev latency ms 39.66% 0.81 0.58
Transfer Mb 13.65% 450.65 396.54
Connect errors NaN% 0 0
Read errors NaN% 0 0
Write errors NaN% 0 0
Status errors (not 2xx/3xx) NaN% 0 0
Timeout errors NaN% 0 0

@github-actions
Copy link

Rust Wrk benchmark report:

Duration: 60 sec, Connections: 64, Threads: 8

Measurement Deviation Current Old
Requests/sec -4.25% 72538.19 75758.6
Total requests -4.32% 4356122 4552619
Total errors NaN% 0 0
Total successes -4.32% 4356122 4552619
Average latency ms -25.00% 0.93 1.24
Minimum latency ms 0.00% 0.02 0.02
Maximum latency ms -49.46% 23.49 46.48
Stdev latency ms -68.20% 0.69 2.17
Transfer Mb -4.32% 452.82 473.25
Connect errors NaN% 0 0
Read errors NaN% 0 0
Write errors NaN% 0 0
Status errors (not 2xx/3xx) NaN% 0 0
Timeout errors NaN% 0 0

@github-actions
Copy link

Rust Wrk benchmark report:

Duration: 60 sec, Connections: 64, Threads: 8

Measurement Deviation Current Old
Requests/sec -9.62% 61484.36 68031.66
Total requests -9.59% 3691945 4083419
Total errors NaN% 0 0
Total successes -9.59% 3691945 4083419
Average latency ms 9.09% 1.08 0.99
Minimum latency ms 0.00% 0.02 0.02
Maximum latency ms 36.79% 28.63 20.93
Stdev latency ms -2.82% 0.69 0.71
Transfer Mb -9.59% 383.78 424.47
Connect errors NaN% 0 0
Read errors NaN% 0 0
Write errors NaN% 0 0
Status errors (not 2xx/3xx) NaN% 0 0
Timeout errors NaN% 0 0

rcoh
rcoh approved these changes Mar 10, 2022
View reviewed changes
Copy link
Collaborator

@rcoh rcoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, could consider also deprecating the config module.

@Velfi Velfi enabled auto-merge (squash) March 10, 2022 19:32
@github-actions
Copy link

A new generated diff is ready to view.

@github-actions
Copy link

A new doc preview is ready to view.

@github-actions
Copy link

Rust Wrk benchmark report:

Duration: 60 sec, Connections: 64, Threads: 8

Measurement Deviation Current Old
Requests/sec 0.58% 68815.15 68419.9
Total requests 0.59% 4131221 4106968
Total errors NaN% 0 0
Total successes 0.59% 4131221 4106968
Average latency ms 0.00% 0.99 0.99
Minimum latency ms 0.00% 0.02 0.02
Maximum latency ms 32.05% 32.88 24.9
Stdev latency ms 4.35% 0.72 0.69
Transfer Mb 0.59% 429.44 426.92
Connect errors NaN% 0 0
Read errors NaN% 0 0
Write errors NaN% 0 0
Status errors (not 2xx/3xx) NaN% 0 0
Timeout errors NaN% 0 0

@Velfi Velfi merged commit e6d09ea into main Mar 10, 2022
@Velfi Velfi deleted the refactor/rename_Config_to_SdkConfig branch March 10, 2022 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcoh rcoh rcoh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Velfi @rcoh