Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use outputDirectory to resolve plugin path #31

Merged
merged 2 commits into from
Nov 30, 2020
Merged

Use outputDirectory to resolve plugin path #31

merged 2 commits into from
Nov 30, 2020

Conversation

srchase
Copy link
Contributor

@srchase srchase commented Nov 25, 2020

Currently, if an outputDirectory extension property has been configured, the smithyBuildJar task will not resolve the correct projection plugin path. If a projection has been configured, a GradleException will be thrown, however, if no projection is configured and the sources plugin is being used, only a warning will be emitted. This CR updates the resolution of the plugin path when an outputDirectory has been configured.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@srchase srchase merged commit 5cc63b4 into smithy-lang:master Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants