-
Notifications
You must be signed in to change notification settings - Fork 537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Honor outputFormat Parameter #117
Conversation
…on the request in Default mode
…r than the host machine
-w /development \ | ||
amazonlinux:2018.03 ./package.sh $DIST_OUTPUT_BUCKET $TEMPLATE_OUTPUT_BUCKET $VERSION | ||
``` | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added this so I could locally have a repeatable build from a non-amazonlinux
distro
@shsenior get a chance to look at this yet? Wasn't sure who the other maintainers were. Feedback welcome. |
@hayesry or anyone else? |
@leviwilson - added for review, thanks for contributing! |
Any news on this? |
Nope. @hayesry is there any sort of information to look to see what the process is for getting PRs into awslabs repositories? There is a lot of interest (or so it seems) from the community and to be honest the cadence in which PRs are reviewed (even well after they are added for review) is incredibly long. From the perspective of those that wish to contribute it's discouraging / disincentivizing if that feedback loop is over a quarter of the year. |
Thanks for your effort here, @leviwilson You can refer to the recent changes here |
@leviwilson would there be a need to be able to provide the options parameter for the toFormat function? https://sharp.pixelplumbing.com/api-output#toformat |
@kjanoudi unsure? The need I'd had was simply to specify the output format, so I didn't dig too much into the other optional arguments. |
Hi there I'd like to set output options to the PNG outputFormat |
Fixes
Description
This PR fixes #116 by allowing the
outputFormat
to be specified in the JSON request when therequestType: "Default"
.This allows for the consumer to control what format the returned image is in according to what is allowable by
Sharp#toFormat
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.