Fixed a bug where Karpenter node labels were accidentally removed #796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for karpenter-docs-prod canceled. 🔨 Explore the source changes: 5f85b5b 🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/618d71d645c4a30007fe6170 |
prateekgogia
suggested changes
Nov 11, 2021
| @@ -74,10 +75,10 @@ func (s *Scheduler) Solve(ctx context.Context, provisioner *v1alpha5.Provisioner | |||
| defer metrics.Measure(schedulingDuration.WithLabelValues(provisioner.Name))() | |||
|
|
|||
| constraints := provisioner.Spec.Constraints.DeepCopy() | |||
| constraints.Labels = functional.UnionStringMaps(constraints.Labels, map[string]string{v1alpha5.ProvisionerNameLabelKey: provisioner.Name}) | |||
There was a problem hiding this comment.
Do we need to store this back to constraints.Labels can we directly pass them to the With() on line 81?
There was a problem hiding this comment.
Yes -- unfortunately this a little bit convoluted. The labels are propagated to nodes, but the requirements aren't. However, we include the labels in the requirements when doing scheduling calculation so that we can ensure pod requirements are met.
There was a problem hiding this comment.
ok I see, what you mean we are using the constraints object later.
prateekgogia
approved these changes
Nov 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Issue, if available:
2. Description of changes:
3. Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.