Removed custom label generation. Refactored scheduling logic in preparation for multiple provisioner selection #791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for karpenter-docs-prod canceled. 🔨 Explore the source changes: e1396c2 🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/618d6560e705f2000943ed54 |
ellistarn
force-pushed
the
nogen
branch
2 times, most recently
from
4c1055e to
681b1b2
Compare
ellistarn
changed the title
ellistarn
force-pushed
the
nogen
branch
2 times, most recently
from
eb637dd to
a095c98
Compare
ellistarn
changed the title
…ration for multiple provisioner selection
pkg/controllers/allocation/filter.go
Outdated
| @@ -82,3 +84,56 @@ func (f *Filter) matchesProvisioner(pod *v1.Pod, provisioner *v1alpha5.Provision | |||
| } | |||
| return fmt.Errorf("matched another provisioner, %s", name) | |||
| } | |||
|
|
|||
| func (f *Filter) hasSupportedSchedulingConstraints(pod *v1.Pod) error { | |||
There was a problem hiding this comment.
I'm not sure it makes sense to introduce new terminology here? Just wondering if Supported might as well be Valid? Or is it actually a new concept? Or maybe call this isValid()?
There was a problem hiding this comment.
Yeah I can call this Validate()
JacobGabrielson
approved these changes
Nov 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Issue, if available:
2. Description of changes:
3. Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.