Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reference latest version 0.3.4 in getting started guide #726

Merged
merged 4 commits into from
Oct 2, 2021

Conversation

bwagner5
Copy link
Contributor

@bwagner5 bwagner5 commented Oct 1, 2021

1. Issue, if available:
N/A

2. Description of changes:

  • Update getting started guide to reference latest version 0.3.4

3. Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: link to issue
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@netlify
Copy link

netlify bot commented Oct 1, 2021

✔️ Deploy Preview for karpenter-docs-prod ready!

🔨 Explore the source changes: af4e19e

🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/615796bc7dd295000895810f

😎 Browse the preview: https://deploy-preview-726--karpenter-docs-prod.netlify.app

@@ -177,7 +177,13 @@ metadata:
spec:
provider:
instanceProfile: KarpenterNodeInstanceProfile-${CLUSTER_NAME}
capacityType: spot
capacityTypes: [spot]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is valid YAML. You need "strings" unless you're using - syntax

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me, but I'll make it uniform to match the rest.

@bwagner5 bwagner5 requested a review from ellistarn October 1, 2021 23:18
@bwagner5 bwagner5 merged commit 1cab1e9 into aws:main Oct 2, 2021
@bwagner5 bwagner5 deleted the doc-patch branch October 2, 2021 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants