Changed Logging configmap to not be overridden in dev workflow #665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for karpenter-docs-prod canceled. 🔨 Explore the source changes: 6859192 🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/61393dd5cc05bf0007ff783d |
njtran
changed the title
| @@ -31,6 +31,3 @@ data: | |||
| "timeEncoder": "iso8601" | |||
| } | |||
| } | |||
| # Log level overrides | |||
| loglevel.controller: info # debug | |||
There was a problem hiding this comment.
I think it would be good to just comment these two lines out (completely) - that way people can see how to change the log level if they wish.
ellistarn
approved these changes
Sep 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Issue, if available:
Possibly related to this issue #649
2. Description of changes:
When doing
make applyto test local changes, we apply the configmap yaml, where the overrides will set the log level back to the info level regardless of if the developer wants it to be at the debug level.3. Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.