update pull request template #657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for karpenter-docs-prod canceled. 🔨 Explore the source changes: ade70ab 🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/6138be613b6dfb0008115e30 |
geoffcline
previously approved these changes
Sep 7, 2021
ellistarn
reviewed
Sep 7, 2021
.github/PULL_REQUEST_TEMPLATE.md
Outdated
|
|
||
|
|
||
| **3. Do the changes impact the accuracy of information at https://karpenter.sh -- especially the [Getting Started Guide](https://karpenter.sh/docs/getting-started) or [Development Guide](https://karpenter.sh/docs/development-guide)?** YES/NO | ||
| * **3.1. If yes, does this PR include updates?** YES/NO |
There was a problem hiding this comment.
We can collapse these into: Related docs issue (or N/A):
There was a problem hiding this comment.
Without being so verbose, can we directly indicate that for docs impacting PRs, we expect an issue to be created?
Perhaps:
Does this change impact docs?
- yes, PR includes docs updates
- yes, issue opened
- no
geoffcline
approved these changes
Sep 8, 2021
Comment on lines
+7
to
+11
| **3. Does this change impact docs?** | ||
| - [ ] Yes, PR includes docs updates | ||
| - [ ] Yes, issue opened: *link to issue* | ||
| - [ ] No | ||
|
|
bwagner5
approved these changes
Sep 8, 2021
|
merge'd |
gfcroft
pushed a commit
to gfcroft/karpenter-provider-aws
that referenced
this pull request
Nov 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue, if available:
Description of changes:
Add reminders to the PR template to update docs on https://karpenter.sh.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.