Auto-discover caBundle when missing (take 2) #655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
September 2, 2021 10:50
also turns out non-test code was broken by my os.FS change
added 5 commits
September 2, 2021 10:50
... instead of rest.InClusterConfig() - this will work in more scenarios, such as when Karpenter is not running inside of the cluster
1. wasn't finding CAData because it wasn't populated 2. use of controllerruntime in shared code (w/ webhook) was causing init()-time crash
|
✔️ Deploy Preview for karpenter-docs-prod canceled. 🔨 Explore the source changes: e75ebd1 🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/61316377d78e170007700c58 |
ellistarn
reviewed
Sep 2, 2021
| encoded := base64.StdEncoding.EncodeToString(binary) | ||
| return &encoded, nil | ||
| _, err = transport.TLSConfigFor(transportConfig) // fills in CAData! | ||
| logging.FromContext(ctx).Infof("Discovered caBundle, length %d", len(transportConfig.TLS.CAData)) |
There was a problem hiding this comment.
This should minimally be a debug statement like the other discovery bits. How often does this log line print?
There was a problem hiding this comment.
Only when creating a launch template
ellistarn
reviewed
Sep 2, 2021
pkg/utils/restconfig/restconfig.go
Outdated
| type contextKey string | ||
|
|
||
| const ( | ||
| restKey contextKey = "restKey" |
There was a problem hiding this comment.
consider a struct and this style: https://github.com/knative/pkg/blob/b558677ab03404ed118ba3e179a7438fe2d8509a/apis/contexts.go#L28
ellistarn
reviewed
Sep 2, 2021
ellistarn
previously approved these changes
Sep 2, 2021
ellistarn
approved these changes
Sep 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue, if available:
This is a prerequisite for #626 but does not fix it.
Description of changes:
fix problems with https://github.com/awslabs/karpenter/pull/636/files
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.