Add Favicon and Brand Images #541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for karpenter-docs-prod canceled. 🔨 Explore the source changes: c459aff 🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/60fb476a45eb3e0007e034e0 |
|
Before merging can someone with a mac test it in safari? The favicon should switch color with light/dark mode. Right now it switches between #5c62b0 and #8890e2 which are the banner colors but we can make it switch between black/white if we like that batter. |
akestner
reviewed
Jul 23, 2021
akestner
reviewed
Jul 23, 2021
|
Attaching screenshots of light/dark mode in safari on macos.
|
akestner
approved these changes
Jul 23, 2021
|
Good catch. Just removed the overview image (deleted) and updated the other two links. |
akestner
approved these changes
Jul 23, 2021
ellistarn
pushed a commit
to ellistarn/karpenter-provider-aws
that referenced
this pull request
Jul 26, 2021
* Add docs site favicon * Add other images and fix ico ratio * Remove old /images folder * Remove karpenter overview image * Update image paths for markdown docs
gfcroft
pushed a commit
to gfcroft/karpenter-provider-aws
that referenced
this pull request
Nov 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Adds svg and ico favicons for main site.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.