Cut v0.2.9 release #522
Merged
Cut v0.2.9 release #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akestner
approved these changes
Jul 22, 2021
| @@ -17,7 +17,7 @@ dev: verify test ## Run all steps in the developer loop | |||
|
|
|||
| ci: verify licenses battletest ## Run all steps used by continuous integration | |||
|
|
|||
| release: publish helm docs ## Run all steps in release workflow | |||
| release: codegen publish helm docs ## Run all steps in release workflow | |||
There was a problem hiding this comment.
What changed to necessitate including this here?
There was a problem hiding this comment.
I realized it was missing. It's just an extra safe check that, on release, all of our files have the correct headers, that apidocs are up to date, etc.
| @@ -1,3 +1,17 @@ | |||
| /* | |||
There was a problem hiding this comment.
Are these license headers manually added?
There was a problem hiding this comment.
Added with make codegen
gfcroft
pushed a commit
to gfcroft/karpenter-provider-aws
that referenced
this pull request
Nov 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.