Finally decided to prevent tests from flaking 🤷 #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellistarn
force-pushed
the
race
branch
5 times, most recently
from
e7697bc to
bf03801
Compare
njtran
approved these changes
Jul 1, 2021
| ExpectReconcileSucceeded(controller, provisioner) | ||
| result := []*v1.Pod{} | ||
| for _, pod := range pods { | ||
| result = append(result, ExpectPodExists(c, pod.GetName(), pod.GetNamespace())) |
There was a problem hiding this comment.
Is it necessary to check if len(result) == len(pods)? In other words, can reconciliation succeed, but result in not all pods being bin-packed?
| Expect(env.Client.Delete(ctx, node)).To(Succeed()) | ||
| node = ExpectNodeExists(env.Client, node.Name) |
There was a problem hiding this comment.
As a side note not for this PR, but I think we should add a check here to see if it has a deletionTimestamp set, for good measure.
gfcroft
pushed a commit
to gfcroft/karpenter-provider-aws
that referenced
this pull request
Nov 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #382, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.