Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "v1alpha2 API changes (#477)" (#490)" #491

Merged
merged 2 commits into from
Jun 30, 2021

Conversation

ellistarn
Copy link
Contributor

@ellistarn ellistarn commented Jun 30, 2021

Issue #, if available:

Description of changes:
I believe this was previously broken due to a bad version of controller-gen. Verified working.

➜  karpenter git:(revert) ✗ stern -l karpenter=controller -n karpenter
+ karpenter-controller-7866858778-2p6v8 › manager
karpenter-controller-7866858778-2p6v8 manager 2021-06-30T16:51:07.532Z	INFO	controller-runtime.metrics	metrics server is starting to listen	{"addr": ":8080"}
karpenter-controller-7866858778-2p6v8 manager I0630 16:51:08.542612       1 leaderelection.go:243] attempting to acquire leader lease  karpenter/karpenter-leader-election...
karpenter-controller-7866858778-2p6v8 manager 2021-06-30T16:51:08.542Z	INFO	controller-runtime.manager	starting metrics server	{"path": "/metrics"}
karpenter-controller-7866858778-2p6v8 manager I0630 16:51:25.282568       1 leaderelection.go:253] successfully acquired lease karpenter/karpenter-leader-election
karpenter-controller-7866858778-2p6v8 manager 2021-06-30T16:51:25.282Z	INFO	controller.terminator	Starting EventSource	{"reconcilerGroup": "", "reconcilerKind": "Node", "source": "kind source: /, Kind="}
karpenter-controller-7866858778-2p6v8 manager 2021-06-30T16:51:25.282Z	INFO	controller.provisioner/allocator	Starting EventSource	{"reconcilerGroup": "provisioning.karpenter.sh", "reconcilerKind": "Provisioner", "source": "kind source: /, Kind="}
karpenter-controller-7866858778-2p6v8 manager 2021-06-30T16:51:25.283Z	INFO	controller.provisioner/reallocator	Starting EventSource	{"reconcilerGroup": "provisioning.karpenter.sh", "reconcilerKind": "Provisioner", "source": "kind source: /, Kind="}
karpenter-controller-7866858778-2p6v8 manager 2021-06-30T16:51:25.383Z	INFO	controller.terminator	Starting Controller	{"reconcilerGroup": "", "reconcilerKind": "Node"}
karpenter-controller-7866858778-2p6v8 manager 2021-06-30T16:51:25.383Z	INFO	controller.provisioner/allocator	Starting Controller	{"reconcilerGroup": "provisioning.karpenter.sh", "reconcilerKind": "Provisioner"}
karpenter-controller-7866858778-2p6v8 manager 2021-06-30T16:51:25.383Z	INFO	controller.provisioner/allocator	Starting workers	{"reconcilerGroup": "provisioning.karpenter.sh", "reconcilerKind": "Provisioner", "worker count": 1}
karpenter-controller-7866858778-2p6v8 manager 2021-06-30T16:51:25.383Z	INFO	controller.terminator	Starting workers	{"reconcilerGroup": "", "reconcilerKind": "Node", "worker count": 1}
karpenter-controller-7866858778-2p6v8 manager 2021-06-30T16:51:25.383Z	INFO	controller.provisioner/reallocator	Starting Controller	{"reconcilerGroup": "provisioning.karpenter.sh", "reconcilerKind": "Provisioner"}
karpenter-controller-7866858778-2p6v8 manager 2021-06-30T16:51:25.383Z	INFO	controller.provisioner/reallocator	Starting workers	{"reconcilerGroup": "provisioning.karpenter.sh", "reconcilerKind": "Provisioner", "worker count": 1}
karpenter-controller-7866858778-2p6v8 manager 2021-06-30T16:52:06.306Z	INFO	Found 5 provisionable pods
karpenter-controller-7866858778-2p6v8 manager 2021-06-30T16:52:08.748Z	INFO	Binding pods [default/inflate-7ddf49bff8-bw5wj default/inflate-7ddf49bff8-2k8jv default/inflate-7ddf49bff8-n2n9l default/inflate-7ddf49bff8-dp9p6 default/inflate-7ddf49bff8-bt52t] to node ip-192-168-24-175.us-west-2.compute.internal
karpenter-controller-7866858778-2p6v8 manager 2021-06-30T16:53:21.801Z	INFO	Terminated instance ip-192-168-24-175.us-west-2.compute.internal
karpenter-controller-7866858778-2p6v8 manager 2021-06-30T16:53:21.981Z	INFO	Terminated instance ip-192-168-24-175.us-west-2.compute.internal
karpenter-controller-7866858778-2p6v8 manager 2021-06-30T16:53:21.989Z	ERROR	Controller failed to reconcile kind Node, terminating nodes, removing finalizer from node ip-192-168-24-175.us-west-2.compute.internal, nodes "ip-192-168-24-175.us-west-2.compute.internal" not found
git

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ellistarn ellistarn changed the title Revert Revert "Revert "v1alpha2 API changes (#477)" (#490)" Jun 30, 2021
@ellistarn ellistarn merged commit 3cb806a into aws:main Jun 30, 2021
@ellistarn ellistarn deleted the revert branch June 30, 2021 17:24
gfcroft pushed a commit to gfcroft/karpenter-provider-aws that referenced this pull request Nov 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants