Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for example deployment #469

Merged
merged 8 commits into from
Jun 24, 2021
Merged

Updates for example deployment #469

merged 8 commits into from
Jun 24, 2021

Conversation

rothgar
Copy link
Contributor

@rothgar rothgar commented Jun 22, 2021

Description of changes:

Major differences I made throughout the doc

  • Use semantic line breaks
  • By default assume someone creates a new cluster with 1.20
  • Add commands to tag subnets as needed
  • Add line breaks to long commands
  • Use --query with aws cli instead of relying on jq where possible
  • Add helm repo update
  • Fix label match for karpenter pod
  • Add cluster delete command to cleanup

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@njtran njtran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvements to the doc! Thanks! Just a couple of questions and checks.

docs/aws/README.md Show resolved Hide resolved
docs/aws/README.md Outdated Show resolved Hide resolved
docs/aws/README.md Show resolved Hide resolved
docs/aws/README.md Show resolved Hide resolved
docs/aws/README.md Outdated Show resolved Hide resolved
docs/aws/README.md Outdated Show resolved Hide resolved
docs/aws/README.md Outdated Show resolved Hide resolved
docs/aws/README.md Outdated Show resolved Hide resolved
@rothgar rothgar requested a review from ellistarn June 23, 2021 20:29
docs/aws/README.md Outdated Show resolved Hide resolved
ellistarn
ellistarn previously approved these changes Jun 23, 2021
ellistarn
ellistarn previously approved these changes Jun 23, 2021
Copy link
Contributor

@ellistarn ellistarn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more time, with feeling!

@ellistarn ellistarn merged commit 446a8ee into aws:main Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants