move lowest-n instance type options to generic packing pkg #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellistarn
reviewed
Jun 15, 2021
pkg/packing/packer.go
Outdated
| @@ -28,6 +28,11 @@ import ( | |||
| "k8s.io/apimachinery/pkg/api/resource" | |||
| ) | |||
|
|
|||
| const ( | |||
| // maxInstanceTypes defines the number of instance type options to return to the cloud provider | |||
| maxInstanceTypes = 20 | |||
There was a problem hiding this comment.
Consider making this value public so that cloud providers can override it as necessary. Eventually, this should probably live in a configmap.
ellistarn
previously approved these changes
Jun 15, 2021
JacobGabrielson
approved these changes
Jun 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#438
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.