Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

java: host process exit does not cleanly exist child jsii-runtime process #456

Closed
eladb opened this issue Apr 15, 2019 · 2 comments
Closed

java: host process exit does not cleanly exist child jsii-runtime process #456

eladb opened this issue Apr 15, 2019 · 2 comments
Labels
bug This issue is a bug. closed-for-staleness effort/medium Medium work item – a couple days of effort language/java Related to Java bindings p1

Comments

@eladb
Copy link
Contributor

eladb commented Apr 15, 2019

See aws/aws-cdk#2289

The CDK utilizes the process.exit event to implicitly invoke app.run() and this fails on java.
@eladb eladb changed the title java: host exit does not cleanly exist child jsii-runtime process java: host process exit does not cleanly exist child jsii-runtime process Apr 15, 2019
eladb pushed a commit to aws/aws-cdk that referenced this issue Apr 15, 2019
fix(java-app-template): invoke app.run()
3e3bb5e 
Since the java client for jsii does not cleanly shutdown
the jsii-runtime process, the implicit "app.run()" does not
work, and the app cannot be synthesized.

Fixes #2289

Related: aws/jsii#456
@eladb eladb mentioned this issue Apr 15, 2019
Merged
4 tasks
eladb pushed a commit to aws/aws-cdk that referenced this issue Apr 15, 2019
fix(java-app-template): invoke app.run() (#2300)
47ff448 
Since the java client for jsii does not cleanly shutdown
the jsii-runtime process, the implicit "app.run()" does not
work, and the app cannot be synthesized.

Fixes #2289

Related: aws/jsii#456
@fulghum fulghum added the language/java Related to Java bindings label Apr 22, 2019
@fulghum
Copy link

fulghum commented Jul 9, 2019

I believe Python also still requires app.synth() and doesn't run correctly unless app.synth() is explicitly included in the customer's code.

@RomainMuller RomainMuller added this to the Java Support milestone Jul 30, 2019
@fulghum fulghum added the p1 label Aug 13, 2019
This was referenced Dec 12, 2019
Closed
Open
Open
@RomainMuller RomainMuller added the bug This issue is a bug. label Jan 24, 2020
@RomainMuller RomainMuller removed this from the Java Support milestone Jul 21, 2020
@RomainMuller RomainMuller added the effort/medium Medium work item – a couple days of effort label Aug 11, 2020
@RomainMuller RomainMuller removed their assignment Jun 24, 2021
@github-actions
Copy link
Contributor

This issue has not received any attention in 2 years. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

@github-actions github-actions bot added closing-soon This issue will automatically close in 4 days unless further comments are made. closed-for-staleness and removed closing-soon This issue will automatically close in 4 days unless further comments are made. labels Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug This issue is a bug. closed-for-staleness effort/medium Medium work item – a couple days of effort language/java Related to Java bindings p1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fulghum @RomainMuller @eladb