This repository was archived by the owner on Apr 13, 2023. It is now read-only.
chore!: Remove ttlInSeconds #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onal unix epoch TTL
…cached yarn dependency causing rukus
…can be found by yarn in node_modules/.bin and not requiring a global tsc
…ing git urls... Rolling back so I can test with npm
…ode comment and added to update and bundle paths
…vice and bundleService via constructors
# Conflicts: # package.json
…merge conflict comments...
…Seconds from deployment to persistence via the constructor
…face into mainline # Conflicts: # src/persistence.ts
rsmayda
approved these changes
Aug 19, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
awslabs/fhir-works-on-aws-deployment#290
Description of changes:
Rolling back the addition of ttlInSeconds from persistence and bundle interfaces because we now pass in all configured ttlsInSeconds as a Map<string, number> to the persistence and bundle constructors.
BREAKING CHANGE: Removes ttlInSeconds from the
persistenceinterfaceBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.