-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add basic markdown support #84
Conversation
Using https://github.com/awslabs/aws-encryption-sdk-specification/blob/master/framework/aws-kms/aws-kms-key-arn.md as an example Markdown. On However, the requirements parsing is off by "1". The above produces the following extracted TOML
|
The parser is missing list handling so it's assuming the number is part of the sentence on the previous line. |
728d695
to
4286583
Compare
There is some kind of corner case with
|
In the report, the whole line is not highlighted. |
4286583
to
1b3bfd1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These look good to me.
The ESDK specification parses now with Markdown.
Fixes #9
Description of changes:
This change adds support for citing markdown specifications. I've added a bunch of new tests to make sure nothing broke in the process.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.