Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance Benchmarking and Identification of bottlenecks #1038

Closed
4 of 6 tasks
smivij opened this issue Jun 13, 2023 · 3 comments
Closed
4 of 6 tasks

Performance Benchmarking and Identification of bottlenecks #1038

smivij opened this issue Jun 13, 2023 · 3 comments
Assignees
Milestone

Comments

@smivij
Copy link
Collaborator

smivij commented Jun 13, 2023

Before we GA the SDK we need to benchmark our performance and also improve it where it falls short of the desired performance levels. We need to identify the usage patterns for platforms, services, operations and prioritize accordingly.


Tasks

Preview Give feedback
  1. dayaffe
  2. dayaffe sichanyoo
  3. sichanyoo

Added by @dayaffe 5/21/24

@smivij smivij added the needs-triage This issue or PR still needs to be triaged. label Jun 13, 2023
@smivij smivij added this to the 2023-Q2 milestone Jun 13, 2023
@jbelkins jbelkins modified the milestones: 2023-Q2, GA Jun 19, 2023
@jbelkins jbelkins added needs-investigation and removed needs-triage This issue or PR still needs to be triaged. labels Jun 19, 2023
@smivij smivij changed the title Performance Benchmarking and Improvements Performance Benchmarking and Identification of bottlenecks Mar 7, 2024
@sichanyoo
Copy link
Contributor

There does not exist a cross-SDK standard for accepted benchmarking levels, because it's heavily dependent on the language. Some services to have SLA (e.g., S3Express has SLA for time it takes for operations).

To gauge which part of the SDK to benchmark, take a look at what other SDKs have done.

Also, consider making list of candidates that may take bulk of the time during request/response flow (e.g., signing for request).

Build a reusable benchmarking tool (if needed) on top of SRA observability and use that.

@sichanyoo
Copy link
Contributor

Found a list of recommended metrics for benchmarking:
/BbKeALtIAOEA/Observability-Tracing-Revised#temp:C:LfW8da6814a06f242928dea883e8

@smivij smivij assigned dayaffe and unassigned sichanyoo Mar 26, 2024
@jbelkins jbelkins assigned sichanyoo and unassigned dayaffe Jul 1, 2024
@sichanyoo sichanyoo assigned dayaffe and unassigned sichanyoo Aug 1, 2024
@dayaffe
Copy link
Contributor

dayaffe commented Aug 21, 2024

See /RunBooks/PerformanceMetrics/

@dayaffe dayaffe closed this as completed Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants