Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cloudformation:UpdateStack's NotificationARNs is notification_ar_ns in the SDK #756

Closed
iliana opened this issue Mar 16, 2023 · 3 comments
Closed
Labels
breaking-change This issue requires a breaking change to remediate. bug This issue is a bug. p2 This is a standard priority issue

Comments

@iliana
Copy link

iliana commented Mar 16, 2023

Describe the bug

(Not sure if this or smithy-rs or somewhere else is the right repo...)

https://docs.rs/aws-sdk-cloudformation/0.24.0/aws_sdk_cloudformation/client/fluent_builders/struct.UpdateStack.html#method.notification_ar_ns

This probably shouldn't be spelled notification_ar_ns.

Expected Behavior

It should be spelled notification_arns.

Current Behavior

n/a

Reproduction Steps

n/a

Possible Solution

No response

Additional Information/Context

No response

Version

├── aws-sdk-cloudformation v0.24.0                                                                                                                                                                                                                                                                                              
│   ├── aws-credential-types v0.54.1 (*)                                                                                                                                                                                                                                                                                        
│   ├── aws-endpoint v0.54.1 (*)                                                                                                                                                                                                                                                                                                
│   ├── aws-http v0.54.1 (*)                                                                                                                                                                                                                                                                                                    
│   ├── aws-sig-auth v0.54.1 (*)                                                                                                                                                                                                                                                                                                
│   ├── aws-smithy-async v0.54.4 (*)                                                                                                                                                                                                                                                                                            
│   ├── aws-smithy-client v0.54.4 (*)                                                                                                                                                                                                                                                                                           
│   ├── aws-smithy-http v0.54.4 (*)                                                                                                                                                                                                                                                                                             
│   ├── aws-smithy-http-tower v0.54.4 (*)                                                                                                                                                                                                                                                                                       
│   ├── aws-smithy-json v0.54.4 (*)                                                                                                                                                                                                                                                                                             
│   ├── aws-smithy-query v0.54.4 (*)                                                                                                                                                                                                                                                                                            
│   ├── aws-smithy-types v0.54.4 (*)                                                                                                                                                                                                                                                                                            
│   ├── aws-smithy-xml v0.54.4 (*)                                                                                                                                                                                                                                                                                              
│   ├── aws-types v0.54.1 (*)

Environment details (OS name and version, etc.)

n/a

Logs

No response

@iliana iliana added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Mar 16, 2023
@jdisanti
Copy link
Contributor

Thanks for reporting this! Looks like this field is modeled as NotificationARNs, so it definitely seems like a bug.

@jdisanti jdisanti added breaking-change This issue requires a breaking change to remediate. p2 This is a standard priority issue and removed needs-triage This issue or PR still needs to be triaged. labels Mar 16, 2023
@rcoh
Copy link
Contributor

rcoh commented Oct 30, 2023

Fixed upstream, pending release

@rcoh rcoh added the pending-release This issue will be fixed by an approved PR that hasn't been released yet. label Oct 30, 2023
@rcoh rcoh closed this as completed Nov 2, 2023
Copy link

github-actions bot commented Nov 2, 2023

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@rcoh rcoh removed the pending-release This issue will be fixed by an approved PR that hasn't been released yet. label Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change This issue requires a breaking change to remediate. bug This issue is a bug. p2 This is a standard priority issue
Projects
None yet
Development

No branches or pull requests

3 participants