Next #519
Closed
Next #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…added error handling to from_path_chunk()
|
Hello! thanks for opening this pull request—this is definitely a change worth making. However, this entire repo actually just holds essentially generated code—we actually need the PR in this file: https://github.com/awslabs/smithy-rs/blob/main/rust-runtime/aws-smithy-http/src/byte_stream.rs (note that we recently landed an unreleased refactoring that uses a builder instead). Let me know if you need any help / guidance porting the PR there. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request supersedes PR #517 (which I inadvertently submitted, not understanding how pull requests work, sorry).
Associated functions were added to ByteStream to allow for uploading chunks of data from files, one augments the from_file function and the other the from_path one.
The from_path_chunk function creates its own internal file handle so that it can be called from separate threads.
This submission includes also two examples of how to perform a partial and a multipart file upload.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.