Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[request]: S3 DNS re-lookup on retry #160

Closed
Tracked by #1583 ...
keetonian opened this issue Jul 20, 2021 · 5 comments
Closed
Tracked by #1583 ...

[request]: S3 DNS re-lookup on retry #160

keetonian opened this issue Jul 20, 2021 · 5 comments
Assignees
Labels
bug This issue is a bug. p2 This is a standard priority issue

Comments

@keetonian
Copy link

keetonian commented Jul 20, 2021

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue, please leave a comment

Tell us about your request
I would like the ability to tell the S3 client to force a DNS lookup when retrying a request. This is a recommendation from S3 to improve latency.

Tell us about the problem you're trying to solve. What are you trying to do, and why is it hard?
This is one of the latency improvements suggested by S3:

For latency-sensitive applications, Amazon S3 advises tracking and aggressively retrying slower operations. When you retry a request, we recommend using a new connection to Amazon S3 and performing a fresh DNS lookup.

https://docs.aws.amazon.com/AmazonS3/latest/userguide/optimizing-performance-design-patterns.html

Are you currently working around this issue?
We're not, but we looked into it. We're currently using Rusoto, which would require us to create a custom HttpConnector and create our own DNS retry logic inside of it. It's possible, but would be a pain and require several modifications.

@github-actions
Copy link

Greetings! Sorry to say but this is a very old issue that is probably not getting as much attention as it deserves. We encourage you to check if this is still an issue in the latest release and if you find that this is still a problem, please feel free to open a new one.

@github-actions github-actions bot added the closing-soon This issue will automatically close in 4 days unless further comments are made. label Jul 21, 2022
@jdisanti jdisanti removed the closing-soon This issue will automatically close in 4 days unless further comments are made. label Jul 21, 2022
@jdisanti
Copy link
Contributor

Bad bot.

@jdisanti
Copy link
Contributor

That the SDK doesn't do DNS lookup on retry is actually a bug, so I'm correcting the label on this.

@jdisanti jdisanti added bug This issue is a bug. and removed feature-request A feature should be added or improved. labels Jul 21, 2022
@jdisanti
Copy link
Contributor

jdisanti commented Sep 1, 2022

Issue in hyper that tracks making this possible: hyperium/hyper#2605

@jmklix jmklix added the p2 This is a standard priority issue label Nov 28, 2022
@rcoh rcoh added the pending-release This issue will be fixed by an approved PR that hasn't been released yet. label Mar 14, 2023
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@rcoh rcoh removed the pending-release This issue will be fixed by an approved PR that hasn't been released yet. label Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. p2 This is a standard priority issue
Projects
Archived in project
Development

No branches or pull requests

5 participants