Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom user agent metadata does not appear in User-Agent header #694

Closed
ianbotsf opened this issue Sep 2, 2022 · 1 comment · Fixed by #695
Closed

Custom user agent metadata does not appear in User-Agent header #694

ianbotsf opened this issue Sep 2, 2022 · 1 comment · Fixed by #695
Assignees
Labels
bug This issue is a bug. p2 This is a standard priority issue

Comments

@ianbotsf
Copy link
Contributor

ianbotsf commented Sep 2, 2022

Describe the bug

When setting custom user age metadata via an aws.customMetadata.* system property, the expected values do not show up in requests's User-Agent header. Different metadata set via the aws.frameworkMetadata property do properly show up so this seems to be unique to custom metadata.

Expected behavior

Custom metadata set via aws.customMetadata.* are included in the User-Agent header.

Current behavior

Custom metadata set via aws.customMetadata.* are not included in the User-Agent header.

Steps to Reproduce

Configure DEBUG-level logging and run the following code:

System.setProperty("aws.customMetadata.foo", "bar")
val s3 = S3Client.fromEnvironment { sdkLogMode = SdkLogMode.LogRequest }
s3.listObjectsV2 { bucket = "<some-bucket>" }

View the DEBUG output and inspect the request headers. The User-Agent string contains other metadata but not the custom metadata foo=bar.

Possible Solution

No response

Context

No response

AWS Kotlin SDK version used

0.17.6-SNAPSHOT

Platform (JVM/JS/Native)

OpenJDK Runtime Environment Corretto-17.0.4.8.1 (build 17.0.4+8-LTS)

Operating System and version

Amazon Linux 2

@github-actions
Copy link

github-actions bot commented Sep 9, 2022

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@debora-ito debora-ito added the p2 This is a standard priority issue label Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. p2 This is a standard priority issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants