Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPDX License Identifier has unnecessary '.' #601

Closed
hyandell opened this issue May 4, 2022 · 3 comments
Closed

SPDX License Identifier has unnecessary '.' #601

hyandell opened this issue May 4, 2022 · 3 comments
Assignees

Comments

@hyandell
Copy link

hyandell commented May 4, 2022

Describe the bug

The source code for the Kotlin SDK has an SPDX License Identifier of:

* SPDX-License-Identifier: Apache-2.0.

Could that extra '.' be removed? It is not part of the identifier spec to treat that line like a sentence and so will mean any tooling has to add additional logic to remove the '.', which given '.' is typically in versioning strings is also a bit uncomfortable to go ignoring.

Expected behavior

Not having the '.'

Current behavior

Having the '.'

Steps to Reproduce

Viewing the source.

Possible Solution

No response

Context

No response

AWS Kotlin SDK version used

0.15.0

Platform (JVM/JS/Native)

n/a

Operating System and version

n/a

@hyandell hyandell added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels May 4, 2022
@aajtodd aajtodd removed bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels May 5, 2022
@aajtodd
Copy link
Collaborator

aajtodd commented May 5, 2022

Thanks for reporting this. We will take a look but just to set expectations this isn't something we will probably get to in the short term.

@lucix-aws
Copy link
Contributor

This was addressed in #678, awslabs/smithy-kotlin#687, and awslabs/aws-crt-kotlin#54

@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants