Skip to content

Commit

Permalink
CrypoAlg-556: Enable tests on assembly functions
Browse files Browse the repository at this point in the history
- As per Torben's comments, the tests in `p256-x86_64_test.cc` for the assembly
functions were only enabled for x86_64. In this change, they are enabled
for ARMv8 assembly as well, excluding the functions that are to be implemented.
- Other comments from Torben were also addressed:
  - cleaning up TODOs, globals, #ifdefs
  - removing the gather/scatter routines from `p256-armv8-asm.pl`
    and the corresponding (what I believe is) scattering of the table
    of precomputed points.
- Fixed a typo in a comment in `ecp_nistz256_select_w5`.

Tested on:
- ARMv8 (M6g)
- x86_64 (MacBook)
  • Loading branch information
nebeid committed Oct 7, 2020
1 parent ae08fa6 commit 34022ff
Show file tree
Hide file tree
Showing 2 changed files with 99 additions and 364 deletions.
Loading

0 comments on commit 34022ff

Please sign in to comment.