Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate the types and transformations from the execution code #770

Closed
bassmanitram opened this issue Jan 8, 2024 · 4 comments
Closed

Comments

@bassmanitram
Copy link
Contributor

bassmanitram commented Jan 8, 2024

Would it be possible to separate out the "types" in this crate - including the serde and http::Request transformations from the rest of the code, either via features or via recrating. When I want to simply use the adaptation to http::Request in library code, I have to pull in all the dependencies required by the Hyper interactions. I think it would be cleaner to separate the two aspects.

@calavera
Copy link
Contributor

calavera commented Jan 8, 2024

Feel free to put them in a different module, or reorganize it in a way that helps you. I rather avoid feature flags for this. They were not originally thought to be used externally, but it should be fine.

@bassmanitram
Copy link
Contributor Author

OK, I'll get onto that immediately - thx! (There's always some idiot who says "you know what, all that private code would be REALLY useful in this hack case" :D)

@calavera
Copy link
Contributor

@bassmanitram are you still interested in this change? I don't like to leave issues hanging, so if you're not going to make those changes, I'll close the issue in a few days as it's not something we're planning on doing ourselves.

@calavera calavera closed this as not planned Won't fix, can't repro, duplicate, stale Feb 23, 2024
Copy link

This issue is now closed. Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants