-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: updated project names to aws lambda power tools for typescript #628
Conversation
Hi @goverdhan07 thanks for the PR, will review it early next week. We really appreciate you taking the time to open a PR, next time could you please leave a comment under the issue you've referenced before start working, like asked in the Contributing guidelines? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you again for the PR, it's already looking good, just one minor note:
The various README.md files (both in the proejct root & in the packages roots i.e. packages/logger/README.md
) also mention the existence of Powertools for other runtimes - example. Could you please apply the same naming to that line - i.e. AWS Lambda Powertools for Python, etc.?
I'm going to request a review from a second maintainer so that when we have 2 approvals we can merge it.
Note for other reviewers: There is an occurrence of the name that appears mid document here and that hasn't been updated, I think it should stay as it is as it falls under the usage described here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks for the PR!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR :)
Minor change needed, otherwise looks good.
packages/metrics/README.md
Outdated
@@ -23,7 +23,7 @@ Find the complete project's [documentation here](https://awslabs.github.io/aws-l | |||
|
|||
### Installation | |||
|
|||
The AWS Lambda Powertools TypeScript utilities follow a modular approach, similar to the official [AWS SDK v3 for JavaScript](https://github.com/aws/aws-sdk-js-v3). | |||
The AWS AWS Lambda Powertools for TypeScript utilities follow a modular approach, similar to the official [AWS SDK v3 for JavaScript](https://github.com/aws/aws-sdk-js-v3). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The AWS AWS Lambda Powertools for TypeScript utilities follow a modular approach, similar to the official [AWS SDK v3 for JavaScript](https://github.com/aws/aws-sdk-js-v3). | |
The AWS Lambda Powertools for TypeScript utilities follow a modular approach, similar to the official [AWS SDK v3 for JavaScript](https://github.com/aws/aws-sdk-js-v3). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description of your changes
AWS Lambda Power tools for TypeScript
How to verify this change
Related issues, RFCs
#624
#624
#ZZZZZ
PR status
Is this ready for review?: YES
Is it a breaking change?: NO
Checklist
Breaking change checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.