Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Official support for MyPy #3

Closed
heitorlessa opened this issue May 13, 2021 · 6 comments
Closed

Official support for MyPy #3

heitorlessa opened this issue May 13, 2021 · 6 comments
Assignees
Labels
Proposed Community submited Python

Comments

@heitorlessa
Copy link
Contributor

heitorlessa commented May 13, 2021

Original author: @huonw

Runtime e.g. Python, Java, all of them. Python

Is your feature request related to a problem? Please describe.

As per in the original Lambda Powertools Python Discussions, MyPy isn't officially supported and can fail when type checking Tracer, as an example.

Describe the solution you'd like

Lambda Powertools to consider MyPy customers and include MyPy in the pipeline to make it compliant :-)

Describe alternatives you've considered

Ignoring type errors

Is this something you'd like to contribute if you had guidance?

Additional context

@heitorlessa
Copy link
Contributor Author

As of 1.18.1, we've made substantial progress on here and have only a handful of issues to fix. I'll mark this as shipped once we address all of them and include MyPy in the CI to keep it consistent

@huonw
Copy link

huonw commented Jul 27, 2021

Bug fixes were largely on MyPy errors (~600 to 38) across the entire code base

That's awesome. Thanks for the update!

@heitorlessa
Copy link
Contributor Author

We've got 14 errors now down from 38. More improvements to come as we will make a release dedicated to it, and enable MyPy at CI by default once these are addressed to prevent regressions

@heitorlessa
Copy link
Contributor Author

Just merged. @huonw thank you for your patience on this -- next release will have full Mypy support now!!

@huonw
Copy link

huonw commented Feb 1, 2022

That's exciting! Thanks for the updates

@heitorlessa
Copy link
Contributor Author

Closing as this is now official as of two releases ago ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Proposed Community submited Python
Projects
None yet
Development

No branches or pull requests

3 participants