Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(apigateway): remove indentation in debug_mode #987

Merged

Conversation

heitorlessa
Copy link
Contributor

@heitorlessa heitorlessa commented Jan 31, 2022

Issue #, if available: #972

Description of changes:

This PR removes additional indentation when using debug_mode. While effective for local development it creates additional log events for CloudWatch Logs incurring additional charges; this breaks our tenets hence we revert.

Before

image

After

image

Checklist

Breaking change checklist

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.


View rendered docs/core/event_handler/api_gateway.md

@boring-cyborg boring-cyborg bot added area/event_handlers documentation Improvements or additions to documentation tests labels Jan 31, 2022
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 31, 2022
@github-actions github-actions bot added the bug Something isn't working label Jan 31, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2022

Codecov Report

Merging #987 (916b7e7) into develop (ffa4a35) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #987      +/-   ##
===========================================
- Coverage    99.96%   99.96%   -0.01%     
===========================================
  Files          119      119              
  Lines         5337     5335       -2     
  Branches       608      607       -1     
===========================================
- Hits          5335     5333       -2     
  Partials         2        2              
Impacted Files Coverage Δ
aws_lambda_powertools/event_handler/api_gateway.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffa4a35...916b7e7. Read the comment docs.

@heitorlessa heitorlessa merged commit 0c35e5a into aws-powertools:develop Jan 31, 2022
@heitorlessa heitorlessa deleted the fix/event-handler-debug-mode branch January 31, 2022 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants