-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(logger): clone powertools logger config to any Python logger #927
feat(logger): clone powertools logger config to any Python logger #927
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
quick initial review as it's missing the log level parameter.
They should be able to override log level when copying the config over
973b8f2
to
bc29018
Compare
Codecov Report
@@ Coverage Diff @@
## develop #927 +/- ##
===========================================
+ Coverage 99.88% 99.96% +0.07%
===========================================
Files 118 119 +1
Lines 5272 5322 +50
Branches 605 614 +9
===========================================
+ Hits 5266 5320 +54
+ Misses 2 0 -2
+ Partials 4 2 -2
Continue to review full report at Codecov.
|
Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience! |
**Issue #, if available: aws-powertools/powertools-lambda#40
Description of changes:
This feature allows customers to clone Powertools Logger configuration like level & handler to any registered Python loggers - exclusion, inclusion-only are also supported.
Breaking change checklist
RFC issue #:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.