feat: add metrics metadata #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* develop: docs: customize contributing guide (#77) chore: move blockquotes as hidden comments
Signed-off-by: heitorlessa <[email protected]>
* develop: chore: remove deprecated code before GA (#78)
Signed-off-by: heitorlessa <[email protected]>
Codecov Report
@@ Coverage Diff @@
## develop #81 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 17 17
Lines 469 474 +5
Branches 41 42 +1
=========================================
+ Hits 469 474 +5
Continue to review full report at Codecov.
|
|
Addressed your feedback @cakepietoast that we chatted privately on adding a test for |
* develop: chore: cleanup tests (#79)
heitorlessa
referenced
this pull request
in heitorlessa/aws-lambda-powertools-python
Jun 17, 2020
…tools-python into develop * 'develop' of https://github.com/awslabs/aws-lambda-powertools-python: (104 commits) feat: add metrics metadata (#81) chore: cleanup tests (#79) chore: remove deprecated code before GA (#78) docs: customize contributing guide (#77) chore: move blockquotes as hidden comments chore: update CHANGELOG chore: bump version to 0.11.0 (#76) chore: version bump 0.10.1 fix: default dimension creation now happens when metrics are serialized instead of on metrics constructor (#74) fix: default dimension creation now happens when metrics are serialized instead of on metrics constructor (#74) docs: fix contrast on highlighted code text (#73) feat: improve error handling for log_metrics decorator (#71) chore(deps): bump graphql-playground-html from 1.6.19 to 1.6.25 in /docs feat: add high level imports (#70) fix: correct env var name for publish to pypi test (#69) chore: version bump (#68) feat: add capture_cold_start_metric for log_metrics (#67) chore(deps): bump websocket-extensions from 0.1.3 to 0.1.4 in /docs (#66) feat: automate publishing to pypi (#58) feat: add pre-commit hooks (#64) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #80
Description of changes:
Add support to high cardinal data as metadata in Metrics object.
Exerpt output in CloudWatch Logs
```json:title=cloudwatch_logs.json { "SuccessfulBooking": 1.0, "_aws": { "Timestamp": 1592234975665, "CloudWatchMetrics": [ { "Namespace": "ExampleApplication", "Dimensions": [ [ "service" ] ], "Metrics": [ { "Name": "SuccessfulBooking", "Unit": "Count" } ] } ] }, "service": "booking", "booking_id": "booking_uuid" // highlight-line } ```Docs
Checklist
Breaking change checklist
RFC issue #:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.