Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove deprecated code before GA #78

Merged
merged 4 commits into from
Jun 15, 2020

Conversation

heitorlessa
Copy link
Contributor

@heitorlessa heitorlessa commented Jun 12, 2020

Issue #, if available: #33

Description of changes:

  • Remove deprecated code in Metrics
  • Remove deprecated code in Logger
  • Remove deprecated Models
  • Bring remaining models into each core utility (MetricUnit, LambdaContextModel)
  • Separate Logger formatter into its own file
  • Meet tenets criteria
  • Update tests
  • Update docs
  • PR title follows conventional commit semantics

Breaking change checklist

Ignore if it's not a breaking change

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

codecov-commenter commented Jun 12, 2020

Codecov Report

Merging #78 into develop will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           develop       #78   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           16        17    +1     
  Lines          516       471   -45     
  Branches        49        43    -6     
=========================================
- Hits           516       471   -45     
Impacted Files Coverage Δ
aws_lambda_powertools/metrics/exceptions.py 100.00% <ø> (ø)
aws_lambda_powertools/logging/__init__.py 100.00% <100.00%> (ø)
aws_lambda_powertools/logging/formatter.py 100.00% <100.00%> (ø)
aws_lambda_powertools/logging/lambda_context.py 100.00% <100.00%> (ø)
aws_lambda_powertools/logging/logger.py 100.00% <100.00%> (ø)
aws_lambda_powertools/metrics/__init__.py 100.00% <100.00%> (ø)
aws_lambda_powertools/metrics/base.py 100.00% <100.00%> (ø)
aws_lambda_powertools/metrics/metric.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b9c3e6...acfd083. Read the comment docs.

@heitorlessa heitorlessa requested a review from to-mc June 13, 2020 17:38
@heitorlessa
Copy link
Contributor Author

Adding you @cakepietoast to double check in case I forgot anything - Tests and fixtures have been updated to reflect the new namespace too

@heitorlessa heitorlessa changed the title chore: remove Logger deprecated code chore: remove deprecated code before GA Jun 13, 2020
Copy link
Contributor

@to-mc to-mc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@heitorlessa heitorlessa merged commit 69d5fda into develop Jun 15, 2020
@heitorlessa heitorlessa deleted the chore/remove-deprecated-code branch June 15, 2020 09:17
heitorlessa added a commit that referenced this pull request Jun 15, 2020
* develop:
  chore: remove deprecated code before GA (#78)
heitorlessa referenced this pull request in heitorlessa/aws-lambda-powertools-python Jun 17, 2020
* chore: remove Logger deprecated code

* chore: remove Metrics deprecated code

* chore: remove models from deprecated code

* chore: move logger formatter to its own file
heitorlessa referenced this pull request in heitorlessa/aws-lambda-powertools-python Jun 17, 2020
…tools-python into develop

* 'develop' of https://github.com/awslabs/aws-lambda-powertools-python: (104 commits)
  feat: add metrics metadata (#81)
  chore: cleanup tests (#79)
  chore: remove deprecated code before GA (#78)
  docs: customize contributing guide (#77)
  chore: move blockquotes as hidden comments
  chore: update CHANGELOG
  chore: bump version to 0.11.0 (#76)
  chore: version bump 0.10.1
  fix: default dimension creation now happens when metrics are serialized instead of on metrics constructor (#74)
  fix: default dimension creation now happens when metrics are serialized instead of on metrics constructor (#74)
  docs: fix contrast on highlighted code text (#73)
  feat: improve error handling for log_metrics decorator (#71)
  chore(deps): bump graphql-playground-html from 1.6.19 to 1.6.25 in /docs
  feat: add high level imports (#70)
  fix: correct env var name for publish to pypi test (#69)
  chore: version bump (#68)
  feat: add capture_cold_start_metric for log_metrics (#67)
  chore(deps): bump websocket-extensions from 0.1.3 to 0.1.4 in /docs (#66)
  feat: automate publishing to pypi (#58)
  feat: add pre-commit hooks (#64)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants