fix: metrics default dimension creation

[to-mc]

Issue #, if available: #75

Description of changes:

Change Metrics code to add default "service" dimension when metrics are serialized, rather than just when Metrics is initialized.

• Meet tenets criteria
• Update tests
• Update docs
• PR title follows conventional commit semantics

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

[codecov-commenter]

Codecov Report

Merging #74 into develop will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##           develop       #74   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           16        16           
  Lines          516       516           
  Branches        49        49           
=========================================
  Hits           516       516           

Impacted Files	Coverage Δ
aws_lambda_powertools/metrics/base.py	100.00% <100.00%> (ø)
aws_lambda_powertools/metrics/metrics.py	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8859f27...0125d46. Read the comment docs.

[heitorlessa]

LGTM

…

On Wed, 10 Jun 2020 at 12:38, Tom McCarthy ***@***.***> wrote: *Issue #, if available:* Description of changes: One or two sentences as a summary of what's being changed - Meet tenets criteria <https://awslabs.github.io/aws-lambda-powertools-python/#tenets> - Update tests - Update docs - PR title follows conventional commit semantics <https://github.com/awslabs/aws-lambda-powertools-python/blob/376ec0a2ac0d2a40e0af5717bef42ff84ca0d1b9/.github/semantic.yml#L2> Breaking change checklist Ignore if it's not a breaking change *RFC issue #*: - Migration process documented - Implement warnings (if it can live side by side) By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice. ------------------------------ You can view, comment on, or merge this pull request online at: #74 Commit Summary - fix: default dimension creation now happens when metrics are serialized instead of on metrics constructor File Changes - *M* aws_lambda_powertools/metrics/base.py <https://github.com/awslabs/aws-lambda-powertools-python/pull/74/files#diff-811bacb402fae635652756e85d46e613> (10) - *M* aws_lambda_powertools/metrics/metrics.py <https://github.com/awslabs/aws-lambda-powertools-python/pull/74/files#diff-01510088a6194e2e32e49f3edb59d7e1> (9) - *M* tests/functional/test_metrics.py <https://github.com/awslabs/aws-lambda-powertools-python/pull/74/files#diff-bc44daa0de5496df091f72df3ebcdc43> (57) Patch Links: - https://github.com/awslabs/aws-lambda-powertools-python/pull/74.patch - https://github.com/awslabs/aws-lambda-powertools-python/pull/74.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#74>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAZPQBC2FXQDL25ZPXYHB6TRV5WFBANCNFSM4N2JPZVQ> .