Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add high level imports #70

Merged
merged 7 commits into from
Jun 8, 2020
Merged

Conversation

heitorlessa
Copy link
Contributor

@heitorlessa heitorlessa commented Jun 8, 2020

Issue #, if available:

Description of changes:

One or two sentences as a summary of what's being changed

Breaking change checklist

Ignore if it's not a breaking change

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@heitorlessa heitorlessa changed the title feat: add high level imports [WIP] feat: add high level imports Jun 8, 2020
@codecov-commenter
Copy link

codecov-commenter commented Jun 8, 2020

Codecov Report

Merging #70 into develop will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           develop       #70   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           15        16    +1     
  Lines          508       513    +5     
  Branches        48        48           
=========================================
+ Hits           508       513    +5     
Impacted Files Coverage Δ
aws_lambda_powertools/logging/logger.py 100.00% <ø> (ø)
...ws_lambda_powertools/middleware_factory/factory.py 100.00% <ø> (ø)
aws_lambda_powertools/tracing/tracer.py 100.00% <ø> (ø)
aws_lambda_powertools/metrics/__init__.py 100.00% <100.00%> (ø)
aws_lambda_powertools/metrics/base.py 100.00% <100.00%> (ø)
aws_lambda_powertools/metrics/metric.py 100.00% <100.00%> (ø)
aws_lambda_powertools/metrics/metrics.py 100.00% <100.00%> (ø)
aws_lambda_powertools/package_logger.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 967d86e...504410e. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented Jun 8, 2020

This pull request introduces 1 alert when merging 68d9e52 into 967d86e - view on LGTM.com

new alerts:

  • 1 for Module is imported with 'import' and 'import from'

* develop:
  fix: correct env var name for publish to pypi test (#69)
  chore: version bump (#68)
@heitorlessa heitorlessa changed the title [WIP] feat: add high level imports feat: add high level imports Jun 8, 2020
@heitorlessa heitorlessa requested review from to-mc and nmoutschen June 8, 2020 12:39
@lgtm-com
Copy link

lgtm-com bot commented Jun 8, 2020

This pull request introduces 1 alert when merging c682b59 into 967d86e - view on LGTM.com

new alerts:

  • 1 for Module is imported with 'import' and 'import from'

Copy link
Contributor

@to-mc to-mc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@heitorlessa heitorlessa merged commit 51cdcca into develop Jun 8, 2020
@heitorlessa heitorlessa deleted the feat/high-level-imports branch June 8, 2020 16:03
heitorlessa added a commit that referenced this pull request Jun 10, 2020
* develop: (31 commits)
  docs: fix contrast on highlighted code text (#73)
  feat: improve error handling for log_metrics decorator (#71)
  chore(deps): bump graphql-playground-html from 1.6.19 to 1.6.25 in /docs
  feat: add high level imports (#70)
  fix: correct env var name for publish to pypi test (#69)
  chore: version bump (#68)
  feat: add capture_cold_start_metric for log_metrics (#67)
  chore(deps): bump websocket-extensions from 0.1.3 to 0.1.4 in /docs (#66)
  feat: automate publishing to pypi (#58)
  feat: add pre-commit hooks (#64)
  improv: include example tests in `make tests` (#63)
  chore: rename Makefile target docs-dev to docs-local (#65)
  improv: better namespace/dimension handling for Metrics (#62)
  docs: build on master only
  chore: correct docstring for log_metrics
  chore: fix typo in metrics doc
  chore: Correct test comment
  chore: remove unused import
  chore: formatting
  feat: update Metrics interface to resemble tracer & logger: use "service" as its namespace.
  ...
heitorlessa referenced this pull request in heitorlessa/aws-lambda-powertools-python Jun 17, 2020
* chore: disable fail fast on pre-commit

Signed-off-by: heitorlessa <[email protected]>

* feat: add core utilities as high level imports

* chore: update to high level imports

* fix: flake8 exclude and specific files

* chore: remove fail_fast param completely

Signed-off-by: heitorlessa <[email protected]>

* fix: separate logging import into separate file
heitorlessa referenced this pull request in heitorlessa/aws-lambda-powertools-python Jun 17, 2020
…tools-python into develop

* 'develop' of https://github.com/awslabs/aws-lambda-powertools-python: (104 commits)
  feat: add metrics metadata (#81)
  chore: cleanup tests (#79)
  chore: remove deprecated code before GA (#78)
  docs: customize contributing guide (#77)
  chore: move blockquotes as hidden comments
  chore: update CHANGELOG
  chore: bump version to 0.11.0 (#76)
  chore: version bump 0.10.1
  fix: default dimension creation now happens when metrics are serialized instead of on metrics constructor (#74)
  fix: default dimension creation now happens when metrics are serialized instead of on metrics constructor (#74)
  docs: fix contrast on highlighted code text (#73)
  feat: improve error handling for log_metrics decorator (#71)
  chore(deps): bump graphql-playground-html from 1.6.19 to 1.6.25 in /docs
  feat: add high level imports (#70)
  fix: correct env var name for publish to pypi test (#69)
  chore: version bump (#68)
  feat: add capture_cold_start_metric for log_metrics (#67)
  chore(deps): bump websocket-extensions from 0.1.3 to 0.1.4 in /docs (#66)
  feat: automate publishing to pypi (#58)
  feat: add pre-commit hooks (#64)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants