-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(validator): include missing data elements from a validation error #686
feat(validator): include missing data elements from a validation error #686
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two small changes: 1/ Test to ensure we don't break the previous behaviour, and 2/ Either docs or an example of how to leverage the new attributes to make it presentable
@heitorlessa not sure what to change |
Codecov Report
@@ Coverage Diff @@
## develop #686 +/- ##
========================================
Coverage 99.97% 99.97%
========================================
Files 116 116
Lines 4855 4866 +11
Branches 267 267
========================================
+ Hits 4854 4865 +11
Partials 1 1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot, Mike!
My internet didn't download all details and I couldn't see the tests -- this time I can, just merged, sorry for the confusion |
…tools-python into develop * 'develop' of https://github.com/awslabs/aws-lambda-powertools-python: docs(event-handler): document catch-all routes (aws-powertools#705) chore: add python 3.9 support docs: add team behind it and email ISSUE-693: Use ExpressionAttributeNames in _put_record (aws-powertools#697) feat(validator): include missing data elements from a validation error (aws-powertools#686) chore(deps-dev): bump mkdocs-material from 7.2.8 to 7.3.0 (aws-powertools#695) chore(deps-dev): bump mkdocs-material from 7.2.6 to 7.2.8 (aws-powertools#682) chore(deps-dev): bump flake8-bugbear from 21.4.3 to 21.9.1 (aws-powertools#676) chore(deps): bump boto3 from 1.18.38 to 1.18.41 (aws-powertools#677) chore(deps-dev): bump radon from 4.5.2 to 5.1.0 (aws-powertools#673) chore(deps): bump boto3 from 1.18.32 to 1.18.38 (aws-powertools#671) refactor(data-classes): clean up internal logic for APIGatewayAuthorizerResponse (aws-powertools#643) fix(data-classes): use correct asdict funciton (aws-powertools#666) chore(deps-dev): bump xenon from 0.7.3 to 0.8.0 (aws-powertools#669) chore: bump to 1.20.2 fix: Fix issue with strip_prefixes (aws-powertools#647) chore(deps-dev): bump mkdocs-material from 7.2.4 to 7.2.6 (aws-powertools#665) chore(deps): bump boto3 from 1.18.26 to 1.18.32 (aws-powertools#663) chore(deps-dev): bump pytest from 6.2.4 to 6.2.5 (aws-powertools#662) chore(license): Add THIRD-PARTY-LICENSES (aws-powertools#641)
Issue #, if available:
Description of changes:
Current implementation will just build a message from the
JsonSchemaValueException
like:Which is not presentable and missing some of the data elements. This change updates
SchemaValidationError
to include more data elements fromJsonSchemaValueException
New fields are:
data.property[index] must be smaller than or equal to 42
)data.property[index]
)path
as an array in the data structure (e.g.['data', 'property', 'index']
),definition
(e.g.42
)rule
which thedata
is breaking (e.g.maximum
)definition
(e.g.42
)Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.