Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(event_handler): match to match_results; 3.10 new keyword #616

Merged
merged 2 commits into from
Aug 17, 2021

Conversation

michaelbrewer
Copy link
Contributor

@michaelbrewer michaelbrewer commented Aug 16, 2021

Issue #, if available:

Description of changes:

  • Rename match to match_results
  • fix Docstrings for optionals.

Checklist

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 16, 2021
@codecov-commenter
Copy link

codecov-commenter commented Aug 16, 2021

Codecov Report

Merging #616 (6825fbc) into develop (25f067a) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #616   +/-   ##
========================================
  Coverage    99.95%   99.95%           
========================================
  Files          114      114           
  Lines         4581     4581           
  Branches       249      249           
========================================
  Hits          4579     4579           
  Partials         2        2           
Impacted Files Coverage Δ
...utilities/data_classes/appsync_authorizer_event.py 100.00% <ø> (ø)
aws_lambda_powertools/event_handler/api_gateway.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25f067a...6825fbc. Read the comment docs.

@michaelbrewer michaelbrewer changed the title fix: rename match a python 3.10 reserved word fix: rename var match to match_results a python 3.10 reserved word Aug 17, 2021
@heitorlessa heitorlessa changed the title fix: rename var match to match_results a python 3.10 reserved word fix(event_handler): rename var match to match_results a python 3.10 reserved word Aug 17, 2021
@heitorlessa heitorlessa added the internal Maintenance changes label Aug 17, 2021
@heitorlessa heitorlessa changed the title fix(event_handler): rename var match to match_results a python 3.10 reserved word refactor(event_handler): rename match to match_results due to being a new keyword Aug 17, 2021
@heitorlessa heitorlessa changed the title refactor(event_handler): rename match to match_results due to being a new keyword refactor(event_handler): match to match_results; 3.10 new keyword Aug 17, 2021
@heitorlessa heitorlessa added this to the 1.20.0 milestone Aug 17, 2021
@heitorlessa heitorlessa changed the title refactor(event_handler): match to match_results; 3.10 new keyword refactor(event_handler): match to match_results; 3.10 new keyword Aug 17, 2021
@heitorlessa heitorlessa merged commit 61e7f2d into aws-powertools:develop Aug 17, 2021
@michaelbrewer michaelbrewer deleted the fix-match-reserved-word branch August 17, 2021 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Maintenance changes size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants