Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(feature-toggles): correct cdk example #601

Merged

Conversation

michaelbrewer
Copy link
Contributor

@michaelbrewer michaelbrewer commented Aug 11, 2021

Issue #, if available:

Description of changes:

Current CDK example has indent errors and some special characters (<U+200B>) and corrected json.dumps

Checklist

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@boring-cyborg boring-cyborg bot added the documentation Improvements or additions to documentation label Aug 11, 2021
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 11, 2021
@codecov-commenter
Copy link

codecov-commenter commented Aug 11, 2021

Codecov Report

Merging #601 (dc6e0d3) into develop (2a5be0f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #601   +/-   ##
========================================
  Coverage    99.95%   99.95%           
========================================
  Files          113      113           
  Lines         4535     4535           
  Branches       246      246           
========================================
  Hits          4533     4533           
  Partials         2        2           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4318ac9...dc6e0d3. Read the comment docs.

@michaelbrewer
Copy link
Contributor Author

@heitorlessa - i could not run the CDK example, some weird special characters. This updated example works when i copy and past it.

@heitorlessa heitorlessa added this to the 1.19.0 milestone Aug 11, 2021
@heitorlessa heitorlessa merged commit 1a21b3f into aws-powertools:develop Aug 11, 2021
@michaelbrewer michaelbrewer deleted the docs/feature-flags-cdk-example branch August 15, 2021 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants