-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improv: update metrics interface to resemble other core utils #60
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #60 +/- ##
========================================
Coverage 99.38% 99.39%
========================================
Files 15 15
Lines 489 492 +3
Branches 44 44
========================================
+ Hits 486 489 +3
Misses 3 3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Minor typo only
Are you still planning to add the Could you also change docstring in line 89 in metrics.py:
Thanks again, Tom!! |
Co-authored-by: Heitor Lessa <[email protected]>
I'm in two minds about adding a dimension with the service name. I'll create a separate issue/PR for that to discuss.
Done!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
improv: update metrics interface to resemble other core utils
Issue #, if available: #33
Description of changes: