Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: automate publishing to pypi #58

Merged
merged 6 commits into from
Jun 7, 2020
Merged

feat: automate publishing to pypi #58

merged 6 commits into from
Jun 7, 2020

Conversation

heitorlessa
Copy link
Contributor

@heitorlessa heitorlessa commented Jun 5, 2020 •
edited
Loading

Issue #, if available:

Description of changes:

One or two sentences as a summary of what's being changed

RELEASE PROCESS

Manual activities

  1. Document human readable changes in CHANGELOG
  2. Bump package version using poetry version <major|minor|patch|specific version>
  3. Create a PR to develop branch, and merge if all tests pass
  4. Edit the current draft release notes
  5. If not already set, use v<new version> as a tag, and select develop as target branch

Automated activities

  1. Extract release notes tag that was published
  2. Ensure release notes tag match what's in CHANGELOG and pyproject
  3. Run tests, linting, security and complexity base line
  4. Publish package to PyPi test repository
  5. Publish package to PyPi prod repository
  6. Push latest release source code to master using release title as the commit message

Breaking change checklist

Ignore if it's not a breaking change

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@heitorlessa heitorlessa requested review from to-mc and nmoutschen June 5, 2020 15:46
@heitorlessa heitorlessa mentioned this pull request Jun 5, 2020
Closed
30 tasks
to-mc
to-mc reviewed Jun 5, 2020
View reviewed changes
Copy link
Contributor

@to-mc to-mc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove PYPI_USERNAME and TWINE_USERNAME vars since we're using api tokens?

@heitorlessa heitorlessa self-assigned this Jun 6, 2020
@heitorlessa
Copy link
Contributor Author

Can we remove PYPI_USERNAME and TWINE_USERNAME vars since we're using api tokens?

Are they optional now, Tom? TWINE_USERNAME was a typo, meant to have PYPI_USERNAME only - https://pypi.org/help/#apitoken

@heitorlessa
fix: PYPI_USERNAME typo
b2e9b1c 
Signed-off-by: heitorlessa <[email protected]>
@to-mc
Copy link
Contributor

to-mc commented Jun 6, 2020 •
edited
Loading

Can we remove PYPI_USERNAME and TWINE_USERNAME vars since we're using api tokens?

Are they optional now, Tom? TWINE_USERNAME was a typo, meant to have PYPI_USERNAME only - https://pypi.org/help/#apitoken

No, I was mistaken - still need to set it as __token__. Just need to fix the TWINE typo in that case :)

@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2020 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (develop@7cab984). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop      #58   +/-   ##
==========================================
  Coverage           ?   99.38%           
==========================================
  Files              ?       15           
  Lines              ?      489           
  Branches           ?       44           
==========================================
  Hits               ?      486           
  Misses             ?        3           
  Partials           ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cab984...b2e9b1c. Read the comment docs.

@heitorlessa heitorlessa merged commit c4d090b into aws-powertools:develop Jun 7, 2020
@heitorlessa heitorlessa deleted the feat/automate-pypi-publish branch June 7, 2020 17:54
heitorlessa added a commit that referenced this pull request Jun 10, 2020
@heitorlessa
merge latest stable fixes from develop branch
d87f82b 
* develop: (31 commits)
  docs: fix contrast on highlighted code text (#73)
  feat: improve error handling for log_metrics decorator (#71)
  chore(deps): bump graphql-playground-html from 1.6.19 to 1.6.25 in /docs
  feat: add high level imports (#70)
  fix: correct env var name for publish to pypi test (#69)
  chore: version bump (#68)
  feat: add capture_cold_start_metric for log_metrics (#67)
  chore(deps): bump websocket-extensions from 0.1.3 to 0.1.4 in /docs (#66)
  feat: automate publishing to pypi (#58)
  feat: add pre-commit hooks (#64)
  improv: include example tests in `make tests` (#63)
  chore: rename Makefile target docs-dev to docs-local (#65)
  improv: better namespace/dimension handling for Metrics (#62)
  docs: build on master only
  chore: correct docstring for log_metrics
  chore: fix typo in metrics doc
  chore: Correct test comment
  chore: remove unused import
  chore: formatting
  feat: update Metrics interface to resemble tracer & logger: use "service" as its namespace.
  ...
heitorlessa referenced this pull request in heitorlessa/aws-lambda-powertools-python Jun 17, 2020
@heitorlessa
feat: automate publishing to pypi (#58)
b40c9bd 
* feat: automate publishing to pypi

* feat: ensure version is in package and changelog

* feat: sync up master after release

Signed-off-by: heitorlessa <[email protected]>

* chore: document release process in action

Signed-off-by: heitorlessa <[email protected]>

* improv: use exact match for release tag version

Signed-off-by: heitorlessa <[email protected]>

* fix: PYPI_USERNAME typo

Signed-off-by: heitorlessa <[email protected]>
heitorlessa referenced this pull request in heitorlessa/aws-lambda-powertools-python Jun 17, 2020
@heitorlessa
Merge branch 'develop' of https://github.com/awslabs/aws-lambda-power…
a8e8e50 
…tools-python into develop

* 'develop' of https://github.com/awslabs/aws-lambda-powertools-python: (104 commits)
  feat: add metrics metadata (#81)
  chore: cleanup tests (#79)
  chore: remove deprecated code before GA (#78)
  docs: customize contributing guide (#77)
  chore: move blockquotes as hidden comments
  chore: update CHANGELOG
  chore: bump version to 0.11.0 (#76)
  chore: version bump 0.10.1
  fix: default dimension creation now happens when metrics are serialized instead of on metrics constructor (#74)
  fix: default dimension creation now happens when metrics are serialized instead of on metrics constructor (#74)
  docs: fix contrast on highlighted code text (#73)
  feat: improve error handling for log_metrics decorator (#71)
  chore(deps): bump graphql-playground-html from 1.6.19 to 1.6.25 in /docs
  feat: add high level imports (#70)
  fix: correct env var name for publish to pypi test (#69)
  chore: version bump (#68)
  feat: add capture_cold_start_metric for log_metrics (#67)
  chore(deps): bump websocket-extensions from 0.1.3 to 0.1.4 in /docs (#66)
  feat: automate publishing to pypi (#58)
  feat: add pre-commit hooks (#64)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmoutschen nmoutschen nmoutschen approved these changes

@to-mc to-mc to-mc approved these changes

Assignees

@heitorlessa heitorlessa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@heitorlessa @to-mc @codecov-commenter @nmoutschen