Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: introduce event handlers utility section #388

Merged
merged 8 commits into from
Apr 8, 2021
Merged

docs: introduce event handlers utility section #388

merged 8 commits into from
Apr 8, 2021

Conversation

heitorlessa
Copy link
Contributor

@heitorlessa heitorlessa commented Apr 7, 2021 •
edited
Loading

Issue #, if available: #356

Description of changes:

Checklist

  • Meet tenets criteria
  • Update tests
  • Update docs
  • PR title follows conventional commit semantics
  • Getting started section
  • Advanced section
  • Key features specific to AppSync
  • Required infra
  • Create AppSync Direct Lambda Resolver example
  • Explain difference between resolve vs resolver
  • Nested mappings
  • Async functions
  • Optional: Accessing parent field objects with source

Breaking change checklist

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@heitorlessa heitorlessa added the documentation Improvements or additions to documentation label Apr 7, 2021
@heitorlessa heitorlessa added this to the 1.14.0 milestone Apr 7, 2021
@heitorlessa heitorlessa marked this pull request as draft April 7, 2021 15:43
@heitorlessa heitorlessa marked this pull request as ready for review April 8, 2021 13:38
@heitorlessa
Copy link
Contributor Author

cc @michaelbrewer in case I forgot anything. That's the last pending activity before we release 1.14.0

michaelbrewer
michaelbrewer approved these changes Apr 8, 2021
View reviewed changes
Copy link
Contributor

@michaelbrewer michaelbrewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks ! 👍🏼

michaelbrewer
michaelbrewer approved these changes Apr 8, 2021
View reviewed changes
Copy link
Contributor

@michaelbrewer michaelbrewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@heitorlessa heitorlessa merged commit a64f766 into aws-powertools:develop Apr 8, 2021
@heitorlessa heitorlessa deleted the docs/event-handlers branch April 13, 2021 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelbrewer michaelbrewer michaelbrewer approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.
2 participants
@heitorlessa @michaelbrewer