-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add S3 lambda event support to Parser utility #224 #225
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #225 +/- ##
========================================
Coverage 99.88% 99.88%
========================================
Files 70 71 +1
Lines 2600 2650 +50
Branches 109 109
========================================
+ Hits 2597 2647 +50
Misses 3 3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome - two questions as with the other PRs:
- Could you please update the docs on this new model?
- Do we want to cover S3 Batch Operations too?
On 2, here's the example payload which seems pretty quick to create a model from: https://docs.aws.amazon.com/lambda/latest/dg/services-s3-batch.html
Sure, i'll try my best |
thanks a lot as always @risenberg-cyberark - As discussed, I'll commit these suggestions, and will try pushing the docs to your branch then merge. Failing that, I'll merge as-is, then send another PR with docs and suggestions implemented ;) ETA: This Friday EOD |
* develop: docs: add CW Logs as a supported envelope fix: cloudwatch logs envelope typo docs: add CW Logs as a supported model docs: add Alb as a supported model docs: shadow sidebar to remain expanded cr fixes feat: Add cloudwatch lambda event support to Parser utility feat: Add alb lambda event support to Parser utility #228
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs added - Merging
Issue #, if available:
feat: Add S3 lambda event support to Parser utility #224
Added schema files and tests to parser utility