Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add S3 lambda event support to Parser utility #224 #225

Merged
merged 3 commits into from
Dec 4, 2020

Conversation

ran-isenberg
Copy link
Contributor

Issue #, if available:
feat: Add S3 lambda event support to Parser utility #224

Added schema files and tests to parser utility

@codecov-io
Copy link

codecov-io commented Nov 29, 2020

Codecov Report

Merging #225 (240dd60) into develop (fa34d82) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #225   +/-   ##
========================================
  Coverage    99.88%   99.88%           
========================================
  Files           70       71    +1     
  Lines         2600     2650   +50     
  Branches       109      109           
========================================
+ Hits          2597     2647   +50     
  Misses           3        3           
Impacted Files Coverage Δ
...bda_powertools/utilities/parser/models/__init__.py 100.00% <100.00%> (ø)
...ws_lambda_powertools/utilities/parser/models/s3.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa34d82...240dd60. Read the comment docs.

@heitorlessa heitorlessa added area/utilities feature New feature or functionality labels Dec 1, 2020
Copy link
Contributor

@heitorlessa heitorlessa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome - two questions as with the other PRs:

  1. Could you please update the docs on this new model?
  2. Do we want to cover S3 Batch Operations too?

Docs portion: https://github.com/awslabs/aws-lambda-powertools-python/blob/develop/docs/content/utilities/parser.mdx#extending-built-in-models

On 2, here's the example payload which seems pretty quick to create a model from: https://docs.aws.amazon.com/lambda/latest/dg/services-s3-batch.html

@heitorlessa heitorlessa self-assigned this Dec 1, 2020
@ran-isenberg
Copy link
Contributor Author

Awesome - two questions as with the other PRs:

  1. Could you please update the docs on this new model?
  2. Do we want to cover S3 Batch Operations too?

Docs portion: https://github.com/awslabs/aws-lambda-powertools-python/blob/develop/docs/content/utilities/parser.mdx#extending-built-in-models

On 2, here's the example payload which seems pretty quick to create a model from: https://docs.aws.amazon.com/lambda/latest/dg/services-s3-batch.html

Sure, i'll try my best

@heitorlessa
Copy link
Contributor

thanks a lot as always @risenberg-cyberark - As discussed, I'll commit these suggestions, and will try pushing the docs to your branch then merge. Failing that, I'll merge as-is, then send another PR with docs and suggestions implemented ;)

ETA: This Friday EOD

* develop:
  docs: add CW Logs as a supported envelope
  fix: cloudwatch logs envelope typo
  docs: add CW Logs as a supported model
  docs: add Alb as a supported model
  docs: shadow sidebar to remain expanded
  cr fixes
  feat: Add cloudwatch lambda event support to Parser utility
  feat: Add alb lambda event support to Parser utility #228
Copy link
Contributor

@heitorlessa heitorlessa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs added - Merging

@heitorlessa heitorlessa merged commit b82ea7a into aws-powertools:develop Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants