Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add faq section #202

Merged
merged 1 commit into from
Nov 3, 2020
Merged

docs: add faq section #202

merged 1 commit into from
Nov 3, 2020

Conversation

Nr18
Copy link

@Nr18 Nr18 commented Nov 2, 2020 •
edited
Loading

Issue #, if available:

Description of changes:

  • add instructions on how you could enable botocore and boto3 logs

Checklist

Breaking change checklist

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Nr18 Nr18 mentioned this pull request Nov 2, 2020
Closed
heitorlessa
heitorlessa suggested changes Nov 2, 2020
View reviewed changes
Copy link
Contributor

@heitorlessa heitorlessa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for writing this out ;)

One minor improvement only

docs/content/core/logger.mdx Outdated Show resolved Hide resolved
docs/content/core/logger.mdx Outdated Show resolved Hide resolved
docs: add faq section
9423d08 
- add instructions how you could enable botocore and boto3 logs
heitorlessa
heitorlessa approved these changes Nov 3, 2020
View reviewed changes
Copy link
Contributor

@heitorlessa heitorlessa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks a lot for this @Nr18 !!

@heitorlessa heitorlessa added the documentation Improvements or additions to documentation label Nov 3, 2020
@heitorlessa heitorlessa merged commit fd2e5f9 into aws-powertools:develop Nov 3, 2020
@Nr18 Nr18 deleted the logger-faq branch November 3, 2020 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heitorlessa heitorlessa heitorlessa approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nr18 @heitorlessa