fix: add missing tests, correct calls to DictWrapper constructor and improve metrics type hints #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: * validator - Add test for the validator decator with an envelope * data_classes - Call DictWrapper constructor with the nested dict
michaelbrewer
changed the title
michaelbrewer
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #168 +/- ##
============================================
+ Coverage 99.90% 100.00% +0.09%
============================================
Files 52 52
Lines 2151 2151
Branches 96 96
============================================
+ Hits 2149 2151 +2
+ Misses 1 0 -1
+ Partials 1 0 -1
Continue to review full report at Codecov.
|
heitorlessa
reviewed
Sep 21, 2020
heitorlessa
suggested changes
Sep 21, 2020
There was a problem hiding this comment.
Thanks for those changes @michaelbrewer, and for catching an issue with the data_classes utilities.
Could you update description to reflect what changed here? Title reflects validator test only.
One minor issue with type hint as it should've been float over int due to value, and numeric tower also catches int as part of float
michaelbrewer
changed the title
Co-authored-by: Heitor Lessa <[email protected]>
heitorlessa
reviewed
Sep 21, 2020
Co-authored-by: Heitor Lessa <[email protected]>
heitorlessa
approved these changes
Sep 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Changes:
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.