chore: fix typos, docstrings and type hints #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: * Fix some of the type hints * Add messing docstrings for parameters * Fix typos
Codecov Report
@@ Coverage Diff @@
## develop #154 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 28 28
Lines 793 793
Branches 72 72
=========================================
Hits 793 793
Continue to review full report at Codecov.
|
to-mc
approved these changes
Sep 2, 2020
|
Thank you @michaelbrewer for improving the API docs and addressing those typos too |
heitorlessa
referenced
this pull request
in heitorlessa/aws-lambda-powertools-python
Sep 11, 2020
* develop: (57 commits) chore: bump version to 1.5.0 (#158) chore(batch): Housekeeping for recent changes (#157) docs: address readability feedbacks chore: add debug logging for sqs batch processing chore: remove middlewares module, moving decorator functionality to base and sqs docs: add detail to batch processing fix: throw exception by default if messages processing fails chore: add test for sqs_batch_processor interface fix: add sqs_batch_processor as its own method docs: simplify documentation more SQS specific focus Update for sqs_batch_processor interface chore: add sqs_batch_processor decorator to simplify interface feat(parameters): transform = "auto" (#133) chore: fix typos, docstrings and type hints (#154) chore: tiny changes for readability fix: ensure debug log event has latest ctx docs: rephrase the wording to make it more clear docs: refactor example; improve docs about creating your own processor refactor: remove references to BaseProcessor. Left BasePartialProcessor docs: add newly created Slack Channel fix: update image with correct sample ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Changes:
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.