Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance: Refactor Idempotency functional tests with DynamoDB Local #1360

Closed
1 of 2 tasks
heitorlessa opened this issue Jul 25, 2022 · 3 comments
Closed
1 of 2 tasks
Labels
internal Maintenance changes

Comments

@heitorlessa
Copy link
Contributor

Summary

As of now, writing tests for Idempotency is more costly than creating features or addressing bugs. This is largely due to the complex Boto stubber setup required - it's error prone.

DynamoDB Local official wording also changed to: Except for the endpoint, applications that run with the downloadable version of Amazon DynamoDB should also work with the DynamoDB web service.

This gives us a good trade-off on performance (slower) and contract (closer, not exactly the same).

Why is this needed?

Reduce operational overhead and cognitive load when dealing with tests in Idempotency. Idempotency tests are the hardest to write across the entire code base, and this can lead to future errors as we try to cut corners to overcome the sheer complexity.

Which area does this relate to?

Idempotency

Solution

Use official Docker Image and create new tests with this approach, then recreate one test at a time to prevent regressions.

Acknowledgment

@heitorlessa heitorlessa added triage Pending triage from maintainers internal Maintenance changes and removed triage Pending triage from maintainers labels Jul 25, 2022
@heitorlessa
Copy link
Contributor Author

This won't be necessary anymore. We completed E2E refactor and will move Idempotency to the new stack to use the real service to reduce maintenance burden with arrange/act

@github-actions
Copy link
Contributor

⚠️COMMENT VISIBILITY WARNING⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

@heitorlessa heitorlessa closed this as not planned Won't fix, can't repro, duplicate, stale Apr 18, 2023
@github-actions
Copy link
Contributor

⚠️COMMENT VISIBILITY WARNING⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Maintenance changes
Projects
None yet
Development

No branches or pull requests

1 participant