Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): lockdown workflow_run by origin #1350

Merged

Conversation

heitorlessa
Copy link
Contributor

@heitorlessa heitorlessa commented Jul 22, 2022

Issue number: #1349

Summary

Changes

Please provide a summary of what's being changed

Introduces workflow_origin input in central workflow that extracts PR information, and only run from the base repo. It updates all workflows that handle PR automation (on new PR, on merge, on PR title)

User experience

Please share what the user experience looks like before and after this change

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@boring-cyborg boring-cyborg bot added the github-actions Pull requests that update Github_actions code label Jul 22, 2022
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 22, 2022
@heitorlessa heitorlessa changed the title chore(ci): confirm workflow_run event chore(ci): lockdown workflow_run by origin Jul 22, 2022
@heitorlessa heitorlessa requested a review from rubenfonseca July 22, 2022 11:41
@github-actions github-actions bot added the internal Maintenance changes label Jul 22, 2022
Copy link
Contributor

@rubenfonseca rubenfonseca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome, just left a small comment on something that might be deleted.

.github/workflows/on_opened_pr.yml Outdated Show resolved Hide resolved
@pull-request-size pull-request-size bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 22, 2022
@heitorlessa
Copy link
Contributor Author

Looks awesome, just left a small comment on something that might be deleted.

Done and thank you!! Merging after CI completes.

@heitorlessa heitorlessa merged commit ce44892 into aws-powertools:develop Jul 22, 2022
@heitorlessa heitorlessa deleted the chore/lockdown-workflow-run branch July 22, 2022 11:48
heitorlessa added a commit to heitorlessa/aws-lambda-powertools-python that referenced this pull request Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github-actions Pull requests that update Github_actions code internal Maintenance changes size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants