Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maintenance: Enforce PR Acknowledgement is present #1334

Closed
2 tasks done
Tracked by #1009
heitorlessa opened this issue Jul 21, 2022 · 1 comment · Fixed by #2112
Closed
2 tasks done
Tracked by #1009

Maintenance: Enforce PR Acknowledgement is present #1334

heitorlessa opened this issue Jul 21, 2022 · 1 comment · Fixed by #2112
Assignees
@leandrodamascena
Labels
tech-debt Technical Debt tasks

Comments

@heitorlessa
Copy link
Contributor

Summary

When creating new PRs, authors follow our template which includes an acknowledgement section: https://github.com/awslabs/aws-lambda-powertools-python/blob/develop/.github/PULL_REQUEST_TEMPLATE.md#acknowledgment

We should extend our on PR opened workflow to also validate whether that section is present.

Why is this needed?

It guarantees license agreement is acknowledged, and more importantly the social contract that PRs should have a related issue to prevent delays or potential closure.

Which area does this relate to?

Automation, Governance

Solution

No response

Acknowledgment
@heitorlessa heitorlessa added triage Pending triage from maintainers internal Maintenance changes labels Jul 21, 2022
@heitorlessa heitorlessa mentioned this issue Jul 25, 2022
Closed
35 tasks
@heitorlessa heitorlessa removed the triage Pending triage from maintainers label Aug 8, 2022
@leandrodamascena leandrodamascena self-assigned this Apr 11, 2023
@leandrodamascena leandrodamascena mentioned this issue Apr 11, 2023
Merged
7 tasks
@github-actions github-actions bot added the pending-release Fix or implementation already in dev waiting to be released label Apr 12, 2023
@leandrodamascena leandrodamascena linked a pull request Apr 12, 2023 that will close this issue
chore(maintenance): validate acknowledgement section is present #2112
Merged
7 tasks
@github-actions
Copy link
Contributor

This is now released under 2.13.0 version!

@github-actions github-actions bot removed the pending-release Fix or implementation already in dev waiting to be released label Apr 14, 2023
@heitorlessa heitorlessa added tech-debt Technical Debt tasks and removed internal Maintenance changes labels Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leandrodamascena leandrodamascena

Labels
tech-debt Technical Debt tasks
Projects
None yet
Milestone
No milestone
2 participants
@heitorlessa @leandrodamascena