Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maintenance: Suggest large PRs to split #1331

Closed
2 tasks done
Tracked by #1009
heitorlessa opened this issue Jul 21, 2022 · 4 comments
Closed
2 tasks done
Tracked by #1009

Maintenance: Suggest large PRs to split #1331

heitorlessa opened this issue Jul 21, 2022 · 4 comments
Labels
tech-debt Technical Debt tasks

Comments

@heitorlessa
Copy link
Contributor

Summary

Task to create a GitHub Action Workflow to suggest authors to split large PRs - that is, any PR labeled with size/XL or size/XXL. There'll always be exceptions like code+docs, etc. Reacting to these labels being added is a good signal to whether we're dropping quality in detriment to very large PRs.

Why is this needed?

Huge PRs makes it difficult to spot potential bugs that tests may not catch, or deviate from our style guide where our automation doesn't have good coverage yet. More importantly, it reduces cognitive load on reviewers.

Which area does this relate to?

Automation, Governance

Solution

No response

Acknowledgment
@heitorlessa heitorlessa added triage Pending triage from maintainers internal Maintenance changes labels Jul 21, 2022
@heitorlessa heitorlessa mentioned this issue Jul 25, 2022
Closed
35 tasks
@heitorlessa heitorlessa removed the triage Pending triage from maintainers label Aug 8, 2022
@heitorlessa heitorlessa self-assigned this Aug 25, 2022
@heitorlessa heitorlessa mentioned this issue Aug 25, 2022
Merged
7 tasks
@github-actions github-actions bot added the pending-release Fix or implementation already in dev waiting to be released label Aug 25, 2022
@heitorlessa heitorlessa removed their assignment Aug 29, 2022
@heitorlessa
Copy link
Contributor Author

fully working now.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2022

⚠️COMMENT VISIBILITY WARNING⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions
Copy link
Contributor

This is now released under 1.29.0 version!

@github-actions github-actions bot removed the pending-release Fix or implementation already in dev waiting to be released label Sep 13, 2022
@leandrodamascena leandrodamascena added the pending-release Fix or implementation already in dev waiting to be released label Sep 13, 2022
@github-actions
Copy link
Contributor

This is now released under 1.29.1 version!

@github-actions github-actions bot removed the pending-release Fix or implementation already in dev waiting to be released label Sep 13, 2022
@heitorlessa heitorlessa added tech-debt Technical Debt tasks and removed internal Maintenance changes labels Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tech-debt Technical Debt tasks
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@heitorlessa @leandrodamascena