fix(logger): clear_state regression on absent standard keys #1088
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #1084 #1087
Description of changes:
When using
clear_state=True
, standard logging keys likelevel, location, timestamp
are no longer being preserved. This is a regression introduced in 1.25.3, when fixing custom formatters for clear_state behaviour. Our tests weren't robust enough for clear_state - this PR adds additional tests to cover gaps we had.Issue was that when
clear_state=True
was used, the default keys (level, location, timestamp) weren't being re-added as part of a newclear_state
method for LambdaPowertoolsFormatter implemented in 1.25.3, hence the regression.Checklist
Breaking change checklist
RFC issue #:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.